Update clang format (#41)

* satisfy nRF24/.github#9
* ran clang-format
* use separate workflow to check code format
* enable dependabot

Author: 2bndy5

.clang-format

@@ -14,13 +14,13 @@ AlignTrailingComments: true
 AllowAllArgumentsOnNextLine: true
 AllowAllConstructorInitializersOnNextLine: true
 AllowAllParametersOfDeclarationOnNextLine: true
-AllowShortEnumsOnASingleLine: true
-AllowShortBlocksOnASingleLine: Always
-AllowShortCaseLabelsOnASingleLine: false
+AllowShortEnumsOnASingleLine: false
+AllowShortBlocksOnASingleLine: Empty
+AllowShortCaseLabelsOnASingleLine: true
 AllowShortFunctionsOnASingleLine: All
 AllowShortLambdasOnASingleLine: All
-AllowShortIfStatementsOnASingleLine: WithoutElse
-AllowShortLoopsOnASingleLine: true
+AllowShortIfStatementsOnASingleLine: Never
+AllowShortLoopsOnASingleLine: false
 AlwaysBreakAfterReturnType: None
 AlwaysBreakBeforeMultilineStrings: false
 AlwaysBreakTemplateDeclarations: Yes
@@ -67,10 +67,7 @@ DeriveLineEnding: false
 DerivePointerAlignment: false
 DisableFormat: false
 EmptyLineBeforeAccessModifier: Always
-# ---
-# only in v13+
-# EmptyLineAfterAccessModifier: Leave
-# ---
+EmptyLineAfterAccessModifier: Leave
 ExperimentalAutoDetectBinPacking: false
 FixNamespaceComments: true
 IncludeBlocks: Preserve
@@ -89,10 +86,7 @@ IncludeCategories:
     CaseSensitive: false
 IncludeIsMainRegex: "(Test)?$"
 IncludeIsMainSourceRegex: ""
-# ---
-# only in v13+
-# IndentAccessModifiers: false
-# ---
+IndentAccessModifiers: false
 IndentCaseLabels: true
 IndentCaseBlocks: false
 IndentGotoLabels: false
@@ -117,15 +111,12 @@ PenaltyExcessCharacter: 1000000
 PenaltyReturnTypeOnItsOwnLine: 60
 PenaltyIndentedWhitespace: 0
 PointerAlignment: Left
-# ---
-# only in v13+
-# ReferenceAlignment: Right
-# ---
+ReferenceAlignment: Pointer
 ReflowComments: true
-# ---
-# only in v13+
-# ShortNamespaceLines: 0
-# ---
+SpacesInLineCommentPrefix:
+  Maximum: -1
+  Minimum: 0
+ShortNamespaceLines: 0
 # Sort**** is about sorting include/using statements alphabetically
 SortIncludes: false
 SortUsingDeclarations: false

.github/dependabot.yml

@@ -0,0 +1,13 @@
+# To get started with Dependabot version updates, you'll need to specify which
+# package ecosystems to update and where the package manifests are located.
+# Please see the documentation for all configuration options:
+# https://docs.github.com/github/administering-a-repository/configuration-options-for-dependency-updates
+
+version: 2
+updates:
+  - package-ecosystem: "github-actions"
+    # Workflow files stored in the
+    # default location of `.github/workflows`
+    directory: "/"
+    schedule:
+      interval: "weekly"

.github/workflows/build_arduino.yml

@@ -2,25 +2,20 @@ name: Arduino CLI build
 
 on:
   pull_request:
-    types: [opened, reopened]
+    branches: [master]
     paths:
       - ".github/workflows/build_arduino.yml"
       - "examples/**"
 
   push:
+    branches: [master]
     paths:
       - ".github/workflows/build_arduino.yml"
       - "examples/**"
 
 jobs:
-  check_formatting:
-    uses: nRF24/.github/.github/workflows/cpp_lint.yaml@main
-    with:
-      ignore: 'utility|clock-arch.c|clock-arch.h|Dns.cpp|Dns.h'
-      extensions: ino,cpp,h
 
   build:
-    needs: check_formatting
     uses: nRF24/.github/.github/workflows/build_arduino.yaml@main
     with:
       sketch-paths: |

.github/workflows/build_platformIO.yml

@@ -2,7 +2,7 @@ name: PlatformIO build
 
 on:
   pull_request:
-    types: [opened, reopened]
+    branches: [master]
     paths:
       - ".github/workflows/build_platformIO.yml"
       - "library.json"
@@ -12,6 +12,7 @@ on:
       - "!Dns.*"
       - "!clock-arch.*"
   push:
+    branches: [master]
     paths:
       - ".github/workflows/build_platformIO.yml"
       - "library.json"
@@ -30,14 +31,8 @@ jobs:
     with:
       deploy-release: ${{ github.event_name == 'release' }}
 
-  check_formatting:
-    uses: nRF24/.github/.github/workflows/cpp_lint.yaml@main
-    with:
-      ignore: 'utility|clock-arch.c|clock-arch.h|Dns.cpp|Dns.h'
-      extensions: ino,cpp,h
-
   build:
-    needs: [check_formatting, validate_lib_json]
+    needs: [validate_lib_json]
     if: 
     uses: nRF24/.github/.github/workflows/build_platformio.yaml@main
     with:

.github/workflows/clang_format.yml

@@ -0,0 +1,14 @@
+name: check code formatting
+
+on:
+    push:
+        branches: [master, v1.x]
+    pull_request:
+        branches: [master, v1.x]
+
+jobs:
+    check_formatting:
+        uses: nRF24/.github/.github/workflows/cpp_lint.yaml@main
+        with:
+            ignore: 'utility|clock-arch.c|clock-arch.h|Dns.cpp|Dns.h'
+            extensions: ino,c,cpp,h

.github/workflows/doxygen.yml

@@ -2,7 +2,7 @@ name: DoxyGen build
 
 on:
   pull_request:
-    types: [opened, reopened]
+    branches: [master]
     paths:
       - "*.h"
       - "docs/**"
@@ -14,6 +14,7 @@ on:
       - "Doxyfile"
       - "library.properties" # get lib version from here
   push:
+    branches: [master]
     paths:
       - "*.h"
       - "docs/**"
@@ -25,7 +26,6 @@ on:
       - "Doxyfile"
       - "library.properties" # get lib version from here
   release:
-    branches: [master]
     types: [published, edited]
   workflow_dispatch:
 

RF24Client.cpp

@@ -352,24 +352,24 @@ void serialip_appcall(void)
                 // Only call this if the TCP window has already been re-opened, the connection is being polled, but no data
                 // has been acked
                 if (!(u->state & (UIP_CLIENT_CLOSE | UIP_CLIENT_REMOTECLOSED)))
-            {
-
-                if (u->windowOpened == true && u->state & UIP_CLIENT_RESTART && millis() - u->restartTime > u->restartInterval)
                 {
-                    u->restartTime = millis();
+
+                    if (u->windowOpened == true && u->state & UIP_CLIENT_RESTART && millis() - u->restartTime > u->restartInterval)
+                    {
+                        u->restartTime = millis();
 #if defined RF24ETHERNET_DEBUG_CLIENT || defined ETH_DEBUG_L1
-                    Serial.println();
-                    Serial.print(millis());
+                        Serial.println();
+                        Serial.print(millis());
     #if UIP_CONNECTION_TIMEOUT > 0
-                    Serial.print(F(" UIPClient Re-Open TCP Window, time remaining before abort: "));
-                    Serial.println(UIP_CONNECTION_TIMEOUT - (millis() - u->connectTimer));
+                        Serial.print(F(" UIPClient Re-Open TCP Window, time remaining before abort: "));
+                        Serial.println(UIP_CONNECTION_TIMEOUT - (millis() - u->connectTimer));
     #endif
 #endif
-                    u->restartInterval += 500;
-                    u->restartInterval = rf24_min(u->restartInterval, 7000);
-                    uip_restart();
+                        u->restartInterval += 500;
+                        u->restartInterval = rf24_min(u->restartInterval, 7000);
+                        uip_restart();
+                    }
                 }
-            }
         }
 
         /*******Close**********/