Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keyboard arrow controls for volume when not on the volume range #957

Open
heff opened this issue Aug 14, 2024 · 0 comments
Open

Add keyboard arrow controls for volume when not on the volume range #957

heff opened this issue Aug 14, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@heff
Copy link
Collaborator

heff commented Aug 14, 2024

At first I thought we might add arrow controls to the mute button to control volume, because it felt odd that didn't work, but looking at the youtube player it looks like they just capture any up and down arrow usage as volume control.

I think we should do something similar. We already do this for left and right arrows, skipping ahead and back.

We should also make the left and right arrows work for volume control when the volume range is specifically selected. This is a range-level detail. The native HTML range will respond to either up/down or left/right arrows. The media chrome range only responds to up/down for some reason. I'm sure there's a reason we'll need to dig up.

@heff heff added the enhancement New feature or request label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant