Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[charts][sparkline] Heavy layerize time #16658

Open
oliviertassinari opened this issue Feb 19, 2025 · 0 comments
Open

[charts][sparkline] Heavy layerize time #16658

oliviertassinari opened this issue Feb 19, 2025 · 0 comments
Labels
bug 🐛 Something doesn't work component: charts This is the name of the generic UI component, not the React module! performance

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented Feb 19, 2025

Steps to reproduce

Steps:

  1. Open https://mui.com/material-ui/getting-started/templates/dashboard/
  2. See the crazy amount of time spent on "layerize"
Screen.Recording.2025-02-19.at.23.32.02.mov

Current behavior

The popover feels really slow.

Expected behavior

The popover feels shart fast as on https://planner.tremor.so/quotes/monitoring.

Context

I don't know about the others, but for me, experiencing this on the dashboard template is a turn-off to adopting Material UI, I can't quite place it (without knowing this issue, and about the others, this is not just this GitHub issue that creates this feeling), but something about the page feels slow.

Now, if we look closer at what is going on with the layerize time. I find

Image Image

It turns out that it's very much related to #16018. If I remove the data grid from the page, I remove all the sparklines, the performance issue goes away.

So this means that each time the popover updates its position, we pay the cost of point 4. in #9799 (comment). By removing all the layers in the Sparkline chart, we fix this problem.

Initially I thought it was about using wrong CSS properties, but this seems to have no link https://lab.skk.moe/css-triggers.

Your environment

"@mui/x-charts": "7.26.0",

Search keywords: -

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: charts This is the name of the generic UI component, not the React module! performance status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Feb 19, 2025
@oliviertassinari oliviertassinari changed the title [charts][sparkline] Heavy layout time on /material-ui/getting-started/templates/dashboard/ [charts][sparkline] Heavy layerize time on /material-ui/getting-started/templates/dashboard/ Feb 19, 2025
@oliviertassinari oliviertassinari changed the title [charts][sparkline] Heavy layerize time on /material-ui/getting-started/templates/dashboard/ [charts][sparkline] Heavy layerize time Feb 19, 2025
@michelengelen michelengelen removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: charts This is the name of the generic UI component, not the React module! performance
Projects
None yet
Development

No branches or pull requests

2 participants