-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incoming SVG size issue - show popup #5
Comments
@cleversomeday I see the problem, but don't know where it comes from or how to resolve it... For some odd reason, the viewBox in the files you provided treats the units as whatever is used in the width / height attribute, which is not the way my Inkscape / Illustrator outputs them... Basically, this is the culprit: My Inkscape outputs the following viewBox for US Letter SVG: I don't know what standard to follow in this case... Will have to dig a bit into the spec to see what software is buggy! |
@cleversomeday I think the browser behaves as intended (when viewBox units of 8.5 11 are passed): Which means that if you want anything to show up in the browser correctly, that viewbox width / height should be set to some multiple of the width / height value. |
I think this is related to my custom Inkscape default document. When I
use the one that comes with Inkscape I do not have this issue. So this
is an edge case you aren't likely to run across again. Thanks for
checking on it and thanks again for this tool.
…On Wed, Oct 30, 2019 at 6:28 PM Maksim Surguy ***@***.***> wrote:
@cleversomeday I think the browser behaves as intended (when viewBox units of 8.5 11 are passed):
Which means that if you want anything to show up in the browser correctly, that viewbox width / height should be set to some multiple of the width / height value.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
@cleversomeday Whew! I'm hoping this is very much an edge case, otherwise I might just ignore the viewbox attribute if the size is below a certain threshold (since people won't see the SVG on the screen at the size it's supposed to be). Which makes me think it would be nice to make some popup letting the user know that viewBox is too small to be rendered. I'll add that as a feature in planning! Also, I know you really want the ability to make SVGs in the tool itself. That's my first priority as I get some time to work on this tool! |
Maks, Thanks so much for your hard work on this tool. Please find attached the SVGs I uploaded and a screen shot of my results (similar for both plain and Inskcape SVG) cnc-text-tool.zip
The text was updated successfully, but these errors were encountered: