From b05a69bb826345927564a9afaff46a038eb43f76 Mon Sep 17 00:00:00 2001 From: Matt Lacey Date: Fri, 9 Jun 2023 10:42:36 +0100 Subject: [PATCH 01/33] Update doc-link-checks.yml to v3.1.4 --- .github/workflows/doc-link-checks.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/doc-link-checks.yml b/.github/workflows/doc-link-checks.yml index 305339e2..38c9137d 100644 --- a/.github/workflows/doc-link-checks.yml +++ b/.github/workflows/doc-link-checks.yml @@ -9,6 +9,6 @@ jobs: steps: - uses: actions/checkout@v2 - name: 'restqa-404-links' - uses: restqa/404-links@v1.0.1 + uses: restqa/404-links@v3.1.4 with: path: 'docs' From c5db063edc5f37a4ba1fb69f43171a57fac0a6cf Mon Sep 17 00:00:00 2001 From: Matt Lacey Date: Fri, 9 Jun 2023 10:43:52 +0100 Subject: [PATCH 02/33] Update doc-link-checks.yml --- .github/workflows/doc-link-checks.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/doc-link-checks.yml b/.github/workflows/doc-link-checks.yml index 38c9137d..a4e664d9 100644 --- a/.github/workflows/doc-link-checks.yml +++ b/.github/workflows/doc-link-checks.yml @@ -9,6 +9,6 @@ jobs: steps: - uses: actions/checkout@v2 - name: 'restqa-404-links' - uses: restqa/404-links@v3.1.4 + uses: restqa/404-links@3.1.4 with: path: 'docs' From 4ecfa124bc7b993741643478b2cd4f713797ee9a Mon Sep 17 00:00:00 2001 From: Matt Lacey Date: Fri, 9 Jun 2023 10:47:17 +0100 Subject: [PATCH 03/33] Update doc-link-checks.yml - use checkout@v3 --- .github/workflows/doc-link-checks.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/doc-link-checks.yml b/.github/workflows/doc-link-checks.yml index a4e664d9..9b7c0fea 100644 --- a/.github/workflows/doc-link-checks.yml +++ b/.github/workflows/doc-link-checks.yml @@ -7,7 +7,7 @@ jobs: check-links: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - name: 'restqa-404-links' uses: restqa/404-links@3.1.4 with: From 113ccfe3f579de54f31a00bda567d732e4de6ef2 Mon Sep 17 00:00:00 2001 From: Matt Lacey Date: Fri, 9 Jun 2023 10:52:13 +0100 Subject: [PATCH 04/33] Create .404-links.yml --- .404-links.yml | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 .404-links.yml diff --git a/.404-links.yml b/.404-links.yml new file mode 100644 index 00000000..e11a55ec --- /dev/null +++ b/.404-links.yml @@ -0,0 +1,6 @@ +folder: docs/ # The folder required to be parsed +httpsOnly: true # enforce only HTTPS links +pullRequestReview: true # If you want a nice review in your pull requests +ignore: + files: + - ./warnings/_template.md # Relative path from the folder shared above From 9c8fc2ae3d8b9a2bd2609e8dcc74027303031e5b Mon Sep 17 00:00:00 2001 From: Matt Lacey Date: Fri, 9 Jun 2023 10:52:50 +0100 Subject: [PATCH 05/33] Update doc-link-checks.yml - remove path specified here --- .github/workflows/doc-link-checks.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/doc-link-checks.yml b/.github/workflows/doc-link-checks.yml index 9b7c0fea..3e49503e 100644 --- a/.github/workflows/doc-link-checks.yml +++ b/.github/workflows/doc-link-checks.yml @@ -10,5 +10,3 @@ jobs: - uses: actions/checkout@v3 - name: 'restqa-404-links' uses: restqa/404-links@3.1.4 - with: - path: 'docs' From ddf5add80419236f3fa1661a8cbfe014f92df809 Mon Sep 17 00:00:00 2001 From: Matt Lacey Date: Fri, 9 Jun 2023 10:55:48 +0100 Subject: [PATCH 06/33] Update .404-links.yml - fix template path --- .404-links.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.404-links.yml b/.404-links.yml index e11a55ec..19e42d44 100644 --- a/.404-links.yml +++ b/.404-links.yml @@ -3,4 +3,4 @@ httpsOnly: true # enforce only HTTPS links pullRequestReview: true # If you want a nice review in your pull requests ignore: files: - - ./warnings/_template.md # Relative path from the folder shared above + - docs/warnings/_template.md From 71bb1ea157905f16bcfd053b45d3df457859557f Mon Sep 17 00:00:00 2001 From: Matt Lacey Date: Fri, 9 Jun 2023 10:56:56 +0100 Subject: [PATCH 07/33] Update installation.md - https link --- docs/installation.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/installation.md b/docs/installation.md index 39069aa8..e40814e5 100644 --- a/docs/installation.md +++ b/docs/installation.md @@ -10,7 +10,7 @@ _If you had it, the preview version should be uninstalled first._ ## Beta builds -Automated builds with the [latest development version](http://vsixgallery.com/extension/RapidXamlToolkit.0dc8e86a-836b-47e5-aa3f-f5e71c15e37a/) of all functionality are available from the [VSIX Gallery](https://www.vsixgallery.com/feedguide). These are produced every time PRs are merged that contain code changes. +Automated builds with the [latest development version](https://vsixgallery.com/extension/RapidXamlToolkit.0dc8e86a-836b-47e5-aa3f-f5e71c15e37a/) of all functionality are available from the [VSIX Gallery](https://www.vsixgallery.com/feedguide). These are produced every time PRs are merged that contain code changes. _A version distributed via MyGet is no longer available._ From 6858d21e63baca907860dc377aeddd796d4b567b Mon Sep 17 00:00:00 2001 From: Matt Lacey Date: Fri, 9 Jun 2023 10:59:12 +0100 Subject: [PATCH 08/33] Update entry.md - fix old links --- Assets/Marketplace/entry.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Assets/Marketplace/entry.md b/Assets/Marketplace/entry.md index 0c726790..36a1c7b4 100644 --- a/Assets/Marketplace/entry.md +++ b/Assets/Marketplace/entry.md @@ -6,7 +6,7 @@ - **Categories** - Coding, Other, Scaffolding - **Tags** - XAML, UWP, WPF, Xamarin.Forms, MVVM, Xamarin - **Pricing Category** - Free -- **Source code repository** - https://github.com/microsoft/rapid-xaml-toolkit +- **Source code repository** - https://github.com/mrlacey/rapid-xaml-toolkit - **Allow Q&A for your extension** - True --- @@ -61,14 +61,14 @@ and generate this ``` -What is generated is based on common conventions but is highly [configurable](https://github.com/microsoft/Rapid-XAML-Toolkit/blob/dev/docs/configuration.md) and with multiple profiles provided by default. +What is generated is based on common conventions but is highly [configurable](https://github.com/mrlacey/Rapid-XAML-Toolkit/blob/main/docs/configuration.md) and with multiple profiles provided by default. ## XAML Analysis Like [Roslyn Analyzers](https://docs.microsoft.com/en-us/visualstudio/code-quality/roslyn-analyzers-overview?view=vs-2019) do for C# and VB·Net, this toolkit can identify potential issues in XAML files and create suggestions, warnings, or errors about the problems. Suggested Actions are also provided to easily fix what is found. -![Screenshot showing some of the issues that analysis can find](https://github.com/microsoft/Rapid-XAML-Toolkit/blob/dev/docs/Assets/xaml-analysis-example.png?raw=true) +![Screenshot showing some of the issues that analysis can find](https://github.com/mrlacey/Rapid-XAML-Toolkit/blob/main/docs/Assets/xaml-analysis-example.png?raw=true) ## Get Involved -[Feedback](https://github.com/microsoft/Rapid-XAML-Toolkit/issues/new/choose) and [contributions](https://github.com/microsoft/Rapid-XAML-Toolkit/blob/dev/CONTRIBUTING.md) welcome. +[Feedback](https://github.com/mrlacey/Rapid-XAML-Toolkit/issues/new/choose) and [contributions](https://github.com/mrlacey/Rapid-XAML-Toolkit/blob/main/CONTRIBUTING.md) welcome. From 4037324cc70548f0d77de6779bbdacd5de966139 Mon Sep 17 00:00:00 2001 From: Matt Lacey Date: Fri, 9 Jun 2023 11:01:20 +0100 Subject: [PATCH 09/33] Update installation.md - remove beta build references --- docs/installation.md | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/docs/installation.md b/docs/installation.md index e40814e5..5112661a 100644 --- a/docs/installation.md +++ b/docs/installation.md @@ -10,9 +10,7 @@ _If you had it, the preview version should be uninstalled first._ ## Beta builds -Automated builds with the [latest development version](https://vsixgallery.com/extension/RapidXamlToolkit.0dc8e86a-836b-47e5-aa3f-f5e71c15e37a/) of all functionality are available from the [VSIX Gallery](https://www.vsixgallery.com/feedguide). These are produced every time PRs are merged that contain code changes. - -_A version distributed via MyGet is no longer available._ +_Beta versions distributed via VSIX Gallery and MyGet are no longer available._ *** From 82eb9d9c08ec7ce6a482475ea9affae9668d4c37 Mon Sep 17 00:00:00 2001 From: Matt Lacey Date: Fri, 9 Jun 2023 11:03:06 +0100 Subject: [PATCH 10/33] Update doc-link-checks.yml - run push to main & PRs only --- .github/workflows/doc-link-checks.yml | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/.github/workflows/doc-link-checks.yml b/.github/workflows/doc-link-checks.yml index 3e49503e..e3d7fde5 100644 --- a/.github/workflows/doc-link-checks.yml +++ b/.github/workflows/doc-link-checks.yml @@ -1,7 +1,10 @@ -name: 404 links +name: 404 link checks - -on: [push] +on: + push: + branches: [ main ] + pull_request: + types: [assigned, opened, synchronize, reopened] jobs: check-links: From 2a93a6e1494a01bb928810f231f8a8cd5bd88d2f Mon Sep 17 00:00:00 2001 From: Matt Lacey Date: Fri, 9 Jun 2023 11:03:58 +0100 Subject: [PATCH 11/33] Update _template.md --- docs/warnings/_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/warnings/_template.md b/docs/warnings/_template.md index 30fd20ab..3c80475d 100644 --- a/docs/warnings/_template.md +++ b/docs/warnings/_template.md @@ -20,4 +20,4 @@ See also -- [](https://) +- [](https://example.com) From 885abd579b6d8a866660f91f3a1f5b90403ae4bb Mon Sep 17 00:00:00 2001 From: Matt Lacey Date: Fri, 9 Jun 2023 11:05:27 +0100 Subject: [PATCH 12/33] Update .404-links.yml - add ignore url --- .404-links.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.404-links.yml b/.404-links.yml index 19e42d44..047cbbe1 100644 --- a/.404-links.yml +++ b/.404-links.yml @@ -2,5 +2,7 @@ folder: docs/ # The folder required to be parsed httpsOnly: true # enforce only HTTPS links pullRequestReview: true # If you want a nice review in your pull requests ignore: + urls: + - https://example.com files: - docs/warnings/_template.md From d5a02cfe0f15e000a02a61e5f0a5cd7b9b492559 Mon Sep 17 00:00:00 2001 From: Matt Lacey Date: Mon, 10 Feb 2025 14:37:01 +0000 Subject: [PATCH 13/33] Create spellchecking.yml Signed-off-by: Matt Lacey --- .github/workflows/spellchecking.yml | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) create mode 100644 .github/workflows/spellchecking.yml diff --git a/.github/workflows/spellchecking.yml b/.github/workflows/spellchecking.yml new file mode 100644 index 00000000..cd142d19 --- /dev/null +++ b/.github/workflows/spellchecking.yml @@ -0,0 +1,21 @@ +name: Spellcheck Action +on: push + +jobs: + build: + name: Spellcheck + runs-on: ubuntu-latest + steps: + # The checkout step + - uses: actions/checkout@v3 + - uses: rojopolis/spellcheck-github-actions@0.46.0 + name: Spellcheck + with: + config_path: config/.spellcheck.yml + task_name: Markdown + output_file: spellcheck-output.txt + - uses: actions/upload-artifact@v4 + if: '!cancelled()' # Do not upload artifact if job was cancelled + with: + name: Spellcheck Output + path: spellcheck-output.txt From 734b7af1d6a509143b891e403c753c6ff49ad65b Mon Sep 17 00:00:00 2001 From: Matt Lacey Date: Mon, 10 Feb 2025 14:37:46 +0000 Subject: [PATCH 14/33] Create .markdownlint.json Signed-off-by: Matt Lacey --- config/.markdownlint.json | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 config/.markdownlint.json diff --git a/config/.markdownlint.json b/config/.markdownlint.json new file mode 100644 index 00000000..b2403b49 --- /dev/null +++ b/config/.markdownlint.json @@ -0,0 +1,6 @@ +{ + "default": true, + "line-length": false, + "commands-show-output": false, + "no-bare-urls": false +} From 2f4ae1949c71c01064ceddf89b74ea5288872257 Mon Sep 17 00:00:00 2001 From: Matt Lacey Date: Mon, 10 Feb 2025 14:38:08 +0000 Subject: [PATCH 15/33] Create wordlist.txt Signed-off-by: Matt Lacey --- config/wordlist.txt | 1 + 1 file changed, 1 insertion(+) create mode 100644 config/wordlist.txt diff --git a/config/wordlist.txt b/config/wordlist.txt new file mode 100644 index 00000000..aa3dc1ea --- /dev/null +++ b/config/wordlist.txt @@ -0,0 +1 @@ +mrlacey From 149a1ffcee2776490a97083ab08fa46c810d7dfe Mon Sep 17 00:00:00 2001 From: Matt Lacey Date: Mon, 10 Feb 2025 14:38:35 +0000 Subject: [PATCH 16/33] Create .spellcheck.yml Signed-off-by: Matt Lacey --- config/.spellcheck.yml | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) create mode 100644 config/.spellcheck.yml diff --git a/config/.spellcheck.yml b/config/.spellcheck.yml new file mode 100644 index 00000000..6901097f --- /dev/null +++ b/config/.spellcheck.yml @@ -0,0 +1,20 @@ +matrix: +- name: Markdown + sources: + - 'docs/*.md' + default_encoding: utf-8 + aspell: + lang: en + dictionary: + wordlists: + - config/wordlist.txt + encoding: utf-8 + pipeline: + - pyspelling.filters.markdown: + markdown_extensions: + - pymdownx.superfences + - pyspelling.filters.html: + comments: false + ignores: + - code + - pre From 8b54b95865c6f40b2a407728dadbef7840ebad71 Mon Sep 17 00:00:00 2001 From: Matt Lacey Date: Mon, 10 Feb 2025 14:39:23 +0000 Subject: [PATCH 17/33] Create markdownlint.yml Signed-off-by: Matt Lacey --- .github/workflows/markdownlint.yml | 14 ++++++++++++++ 1 file changed, 14 insertions(+) create mode 100644 .github/workflows/markdownlint.yml diff --git a/.github/workflows/markdownlint.yml b/.github/workflows/markdownlint.yml new file mode 100644 index 00000000..f5fae023 --- /dev/null +++ b/.github/workflows/markdownlint.yml @@ -0,0 +1,14 @@ +name: Markdownlint Action +on: push + +jobs: + build: + name: Markdownlint + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v4 + - uses: nosborn/github-action-markdown-cli@v3.3.0 + name: Markdownlint + with: + files: . + config_file: "config/.markdownlint.json" From 480379d382aefa4eb12f4957c07ebfd8a2f6f2d6 Mon Sep 17 00:00:00 2001 From: Matt Lacey Date: Mon, 10 Feb 2025 14:52:48 +0000 Subject: [PATCH 18/33] Update features.md - fix typo Signed-off-by: Matt Lacey --- docs/features.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/features.md b/docs/features.md index acc99cb6..8cb5b15a 100644 --- a/docs/features.md +++ b/docs/features.md @@ -30,7 +30,7 @@ The image below shows some of the issues that analysis can find (and fix). See the [full list of all warnings](./warnings/readme.md#rapid-xaml-toolkit---warnings). -Additionaly, it's also possible to: +Additionally, it's also possible to: - Right-click anywhere in a XAML source file and select 'Rapid XAML > Move all hard-coded string to Resource file' to move all hard-coded strings to a resource file. - Right-click on an opening `Grid` tag and easily add Row and Column definitions. From 1812177ab09cfd4abe538497abab1b1c76e6e76b Mon Sep 17 00:00:00 2001 From: Matt Lacey Date: Mon, 10 Feb 2025 14:53:26 +0000 Subject: [PATCH 19/33] Update custom-analysis.md - fix typo Signed-off-by: Matt Lacey --- docs/custom-analysis.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/custom-analysis.md b/docs/custom-analysis.md index 49fbbc3e..9e1da177 100644 --- a/docs/custom-analysis.md +++ b/docs/custom-analysis.md @@ -117,7 +117,7 @@ The generated project also includes example tests to help you verify your analyz ### Please note. While testing your newly developed custom analyzers, you may find that changes you make aren't always immediately showing up. -A possible cause for this can be Visual Studio aggressively caching previoulsy generated and loaded assemblies. To work around this, try: cleaning the whole solution; manually deleting the 'bin' and 'obj' directories; and even restarting VS. +A possible cause for this can be Visual Studio aggressively caching previously generated and loaded assemblies. To work around this, try: cleaning the whole solution; manually deleting the 'bin' and 'obj' directories; and even restarting VS. I recognize this can be frustrating but I haven't yet found a better solution. If you find one, please share it. ## Share your experiences From 65644693d6739c71b0e535f7ffea4fb2e5ea7e0d Mon Sep 17 00:00:00 2001 From: Matt Lacey Date: Mon, 10 Feb 2025 15:01:59 +0000 Subject: [PATCH 20/33] Update profiles.md - fix typos Signed-off-by: Matt Lacey --- docs/profiles.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/profiles.md b/docs/profiles.md index 046cfa0d..18ff6ff6 100644 --- a/docs/profiles.md +++ b/docs/profiles.md @@ -97,7 +97,7 @@ Attribute based placeholders take the form `$att:: Date: Mon, 10 Feb 2025 15:04:36 +0000 Subject: [PATCH 21/33] Update configuring-analysis.md - fix typos Signed-off-by: Matt Lacey --- docs/configuring-analysis.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/configuring-analysis.md b/docs/configuring-analysis.md index f65ee13d..8aa1052a 100644 --- a/docs/configuring-analysis.md +++ b/docs/configuring-analysis.md @@ -6,8 +6,8 @@ The issues reported via XAML Analysis have a default ErrorType ('Error', 'Warnin The ErrorType of a tag determines how it is displayed in Visual Studio. -- **Error** is underlined in code and listed in the 'Errorw' tab in the Error List. -- **Warning** is underlined in code and listed in the 'Warningw' tab in the Error List. +- **Error** is underlined in code and listed in the 'Errors' tab in the Error List. +- **Warning** is underlined in code and listed in the 'Warnings' tab in the Error List. - **Suggestion** is underlined in code and listed in the 'Messages' tab in the Error List. - **Hidden** has an underline hint in code and is not included in the Error List. @@ -43,7 +43,7 @@ The file must contain a JSON formatted list of suppression objects. Each object is made up of: - **FileName** [required] Matching is case sensitive and done from the end of a full file path. No wildcards are supported but you can specify the FileName as '.xaml' for it to be applied to all XAML files. -- **TagErrorCode** [optional] The warnign to suppress. If not specified the suppression will apply to all tags in the file. +- **TagErrorCode** [optional] The warning to suppress. If not specified the suppression will apply to all tags in the file. - **ElementIdentifier** [optional] Used in a `Contains()` match on the full text of the element, and only those that match are suppressed. If not specified (or left blank) then all tags with the errorcode in the specified file will be suppressed. - **Reason** [optional] Nothing is done with this, it's simply a place to justify why the suppression has been added and allows developers to tell their future selves, or others working on the project, why they did this. From 32f5d607e3cc11429c75a3952820afccd848a8bc Mon Sep 17 00:00:00 2001 From: Matt Lacey Date: Mon, 10 Feb 2025 15:07:53 +0000 Subject: [PATCH 22/33] Update wordlist.txt - initial population Signed-off-by: Matt Lacey --- config/wordlist.txt | 62 +++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 62 insertions(+) diff --git a/config/wordlist.txt b/config/wordlist.txt index aa3dc1ea..c79fbf64 100644 --- a/config/wordlist.txt +++ b/config/wordlist.txt @@ -1 +1,63 @@ +AddMissingBarAttribute +AnalysisExe +arg +AutoFix +BuildAnalysis +camelCase +Ctrl +codebase +DependencyObject +dialogs +dll +DynamicResource +ElementIdentifier +elementwithspaces +enum +enumname +errorcode +ErrorType +FileName +incint +intellicode +IntelliCode +JSON +MAUI mrlacey +MVVM +namespace +namewithspaces +nooutput +NuGet +nupkg +PascalCase +pfx +precompiled +RapidXaml +RapidXamlToolkit +repint +repxname +RXT +safename +SDK +sln +subprops +suppressions +TagErrorCode +TargetType +TODO +UI +UWP +UIElement +ViewModel +VM +VSIX +WarnAboutTODOs +WinUI +WPF +xaml +XAML +XamlAnalysisFooElementRequiresBarAttributeDescription +XamlAnalysisFooElementRequiresBarAttributeToolTip +xml +xmlns +xname From f62575bf84b60e139f338886fea7b340a3b88570 Mon Sep 17 00:00:00 2001 From: Matt Lacey Date: Mon, 10 Feb 2025 15:09:51 +0000 Subject: [PATCH 23/33] Update CHANGELOG.md - formatting Signed-off-by: Matt Lacey --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index ba045945..2d0523f2 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -83,7 +83,7 @@ --- -_earlier release notes are summary only_ +Note: _earlier release notes are summary only_ ## 0.10.* From 1b8c0fd086b1ad1984f590549e9a6657ab3cd9ab Mon Sep 17 00:00:00 2001 From: Matt Lacey Date: Mon, 10 Feb 2025 15:10:19 +0000 Subject: [PATCH 24/33] Update CODE-OF-CONDUCT.md - remove multiple blank lines Signed-off-by: Matt Lacey --- CODE-OF-CONDUCT.md | 1 - 1 file changed, 1 deletion(-) diff --git a/CODE-OF-CONDUCT.md b/CODE-OF-CONDUCT.md index 9cfc74b3..6dafb233 100644 --- a/CODE-OF-CONDUCT.md +++ b/CODE-OF-CONDUCT.md @@ -71,4 +71,3 @@ This Code of Conduct is adapted from the [Contributor Covenant][homepage], versi available at https://www.contributor-covenant.org/version/1/4/code-of-conduct.html [homepage]: https://www.contributor-covenant.org - From d900652a475dd18d312c2a91fc13a948f6cad347 Mon Sep 17 00:00:00 2001 From: Matt Lacey Date: Mon, 10 Feb 2025 15:15:13 +0000 Subject: [PATCH 25/33] Update RXT102.md - add final trailing newline Signed-off-by: Matt Lacey --- docs/warnings/RXT102.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/warnings/RXT102.md b/docs/warnings/RXT102.md index eb4aeaa6..21d27508 100644 --- a/docs/warnings/RXT102.md +++ b/docs/warnings/RXT102.md @@ -39,4 +39,4 @@ After additional column definitions have been added, you may need to adjust thei See also - [RXT101 - Use of a Grid.Row value without corresponding RowDefinition](./RXT101.md) -- [RXT104 - Use of a Grid.ColumnSpan value without corresponding ColumnDefinition](./RXT104.md) \ No newline at end of file +- [RXT104 - Use of a Grid.ColumnSpan value without corresponding ColumnDefinition](./RXT104.md) From fba2fcbb394820ca7255f4d5228429a6aefb713d Mon Sep 17 00:00:00 2001 From: Matt Lacey Date: Mon, 10 Feb 2025 15:15:47 +0000 Subject: [PATCH 26/33] Update RELEASE_NOTES.md - linting Signed-off-by: Matt Lacey --- RELEASE_NOTES.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md index f794c11b..d97ec816 100644 --- a/RELEASE_NOTES.md +++ b/RELEASE_NOTES.md @@ -1 +1,3 @@ -please see the [change log](https://github.com/mrlacey/Rapid-XAML-Toolkit/blob/main/CHANGELOG.md) +# Release Notes + +Please see the [change log](https://github.com/mrlacey/Rapid-XAML-Toolkit/blob/main/CHANGELOG.md) From 8608f0fc57003e135da140ebaa2e65216ca22928 Mon Sep 17 00:00:00 2001 From: Matt Lacey Date: Mon, 10 Feb 2025 15:16:16 +0000 Subject: [PATCH 27/33] Update historic-results.md - linting Signed-off-by: Matt Lacey --- VSIX/Benchmarking/historic-results.md | 5 ----- 1 file changed, 5 deletions(-) diff --git a/VSIX/Benchmarking/historic-results.md b/VSIX/Benchmarking/historic-results.md index c6e8fa83..a140a824 100644 --- a/VSIX/Benchmarking/historic-results.md +++ b/VSIX/Benchmarking/historic-results.md @@ -21,13 +21,11 @@ Intel Core i7-8650U CPU 1.90GHz (Kaby Lake R), 1 CPU, 8 logical and 4 physical c [Host] : .NET Core 3.1.8 (CoreCLR 4.700.20.41105, CoreFX 4.700.20.41903), X64 RyuJIT DefaultJob : .NET Core 3.1.8 (CoreCLR 4.700.20.41105, CoreFX 4.700.20.41903), X64 RyuJIT - | Method | Mean | Error | StdDev | Ratio | Rank | Gen 0 | Gen 1 | Gen 2 | Allocated | |------------- |---------:|---------:|---------:|------:|-----:|----------:|----------:|---------:|----------:| | ParseCurrent | 62.49 ms | 0.898 ms | 0.701 ms | 1.00 | 1 | 8000.0000 | 1125.0000 | 500.0000 | 33.9 MB | ``` - ## 0.10.5 (initial perf improvements) Summary results @@ -39,7 +37,6 @@ Intel Core i7-8650U CPU 1.90GHz (Kaby Lake R), 1 CPU, 8 logical and 4 physical c [Host] : .NET Core 3.1.6 (CoreCLR 4.700.20.26901, CoreFX 4.700.20.31603), X64 RyuJIT DefaultJob : .NET Core 3.1.6 (CoreCLR 4.700.20.26901, CoreFX 4.700.20.31603), X64 RyuJIT - | Method | Mean | Error | StdDev | Ratio | Rank | Gen 0 | Gen 1 | Gen 2 | Allocated | |------------- |---------:|---------:|---------:|------:|-----:|-----------:|----------:|------:|----------:| | ParseCurrent | 230.9 ms | 12.24 ms | 34.53 ms | 1.00 | 1 | 11000.0000 | 2000.0000 | - | 47.93 MB | @@ -56,7 +53,6 @@ Intel Core i7-8650U CPU 1.90GHz (Kaby Lake R), 1 CPU, 8 logical and 4 physical c [Host] : .NET Core 3.1.6 (CoreCLR 4.700.20.26901, CoreFX 4.700.20.31603), X64 RyuJIT DefaultJob : .NET Core 3.1.6 (CoreCLR 4.700.20.26901, CoreFX 4.700.20.31603), X64 RyuJIT - | Method | Mean | Error | StdDev | Ratio | Rank | Gen 0 | Gen 1 | Gen 2 | Allocated | |------------- |---------:|---------:|---------:|------:|-----:|-----------:|----------:|------:|----------:| | ParseCurrent | 426.9 ms | 18.65 ms | 53.51 ms | 1.00 | 1 | 18000.0000 | 2000.0000 | - | 79.86 MB | @@ -65,4 +61,3 @@ Intel Core i7-8650U CPU 1.90GHz (Kaby Lake R), 1 CPU, 8 logical and 4 physical c **Notes.** - Mean is better than expected. - Allocated memory is worryingly large. - From f84876e9e70affb5acd448f51300707f48dd8b3c Mon Sep 17 00:00:00 2001 From: Matt Lacey Date: Mon, 10 Feb 2025 15:31:07 +0000 Subject: [PATCH 28/33] Update profiles.md - fix typo Signed-off-by: Matt Lacey --- docs/profiles.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/profiles.md b/docs/profiles.md index 18ff6ff6..cf90c083 100644 --- a/docs/profiles.md +++ b/docs/profiles.md @@ -64,7 +64,7 @@ Only **$name$**, **$incint$**, and **$repint$** placeholders are valid in the su #### Enum Members mapping The mapping used for properties included from the **$members$** placeholder. -Only the **$element$**, **$elementwithspace$** and **$enumname$** placeholders are valid in the enum member output. +Only the **$element$**, **$elementwithspaces$** and **$enumname$** placeholders are valid in the enum member output. ## Placeholders From d1e96039051d3d4d9052b21478e606368d90d2eb Mon Sep 17 00:00:00 2001 From: Matt Lacey Date: Mon, 10 Feb 2025 15:31:54 +0000 Subject: [PATCH 29/33] Update wordlist.txt - add more words for initial setup Signed-off-by: Matt Lacey --- config/wordlist.txt | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/config/wordlist.txt b/config/wordlist.txt index c79fbf64..0065561c 100644 --- a/config/wordlist.txt +++ b/config/wordlist.txt @@ -11,11 +11,13 @@ dialogs dll DynamicResource ElementIdentifier +elementwithspace elementwithspaces enum enumname errorcode ErrorType +FallBack FileName incint intellicode @@ -24,6 +26,7 @@ JSON MAUI mrlacey MVVM +MyGet namespace namewithspaces nooutput @@ -32,6 +35,7 @@ nupkg PascalCase pfx precompiled +PropertyName RapidXaml RapidXamlToolkit repint @@ -50,6 +54,7 @@ UWP UIElement ViewModel VM +vsix VSIX WarnAboutTODOs WinUI From e3c402749c38735923745d127ae2eb8f753dfc08 Mon Sep 17 00:00:00 2001 From: Matt Lacey Date: Mon, 10 Feb 2025 15:34:36 +0000 Subject: [PATCH 30/33] update .gitignore for Rider --- .gitignore | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.gitignore b/.gitignore index 01a9dbaf..576730c0 100644 --- a/.gitignore +++ b/.gitignore @@ -288,6 +288,10 @@ __pycache__/ *.xsd.cs *.secret +#Rider +Rider/.gradle/ +Rider/Build/ + # The following have default versions checked in but are always assummed as unchanged VSIX/RapidXamlToolkit.Tests.Manual/XamlAnalysis/ParseRealDocumentsTests.g.cs VSIX/RapidXamlToolkit.Tests.Manual/Parsers/ParseRealDocumentsTests.g.cs From fa37fbeb9ad5ce85f71d0cbd5537a87972c321b9 Mon Sep 17 00:00:00 2001 From: Matt Lacey Date: Mon, 10 Feb 2025 15:36:41 +0000 Subject: [PATCH 31/33] fix spelling and whitespace issues --- CHANGELOG.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 2d0523f2..52dadd24 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -102,9 +102,9 @@ Note: _earlier release notes are summary only_ ## 0.3.* -- First version available via the marketplace. -- Included latest developements in Generation and Analysis. -- Added Rsolyn ANalyzers for C#. +- First version available via the marketplace. +- Included latest developments in Generation and Analysis. +- Added Roslyn Analyzers for C#. ## 0.2.* From 8940d3eb532ae177c1deed9a080c387e02b471f6 Mon Sep 17 00:00:00 2001 From: Matt Lacey Date: Mon, 10 Feb 2025 15:37:17 +0000 Subject: [PATCH 32/33] md linting - remove heading punctuation --- docs/custom-analysis.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/custom-analysis.md b/docs/custom-analysis.md index 9e1da177..e904a8d1 100644 --- a/docs/custom-analysis.md +++ b/docs/custom-analysis.md @@ -114,7 +114,7 @@ You can reference the project directly, the compiled DLL, or package the library The generated project also includes example tests to help you verify your analyzer is work correctly. They show how you can confirm the analyzer returns the expected response given different XAML strings as input. -### Please note. +### Please note While testing your newly developed custom analyzers, you may find that changes you make aren't always immediately showing up. A possible cause for this can be Visual Studio aggressively caching previously generated and loaded assemblies. To work around this, try: cleaning the whole solution; manually deleting the 'bin' and 'obj' directories; and even restarting VS. From bdaf47d8c22ddbfa127d102dcf8ad271e3e38ad1 Mon Sep 17 00:00:00 2001 From: Matt Lacey Date: Mon, 10 Feb 2025 15:38:18 +0000 Subject: [PATCH 33/33] spelling and linting fixes --- VSIX/Benchmarking/historic-results.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/VSIX/Benchmarking/historic-results.md b/VSIX/Benchmarking/historic-results.md index a140a824..7d2b53fd 100644 --- a/VSIX/Benchmarking/historic-results.md +++ b/VSIX/Benchmarking/historic-results.md @@ -3,7 +3,7 @@ Because any changes can be far reaching, it is not practical to keep all different implementations for comparison. Instead, a copy of the results is kept for comparison with current results. -A benchamarking run involves parsing the five documents in the `files` folder. +A benchmarking run involves parsing the five documents in the `files` folder. This includes analysis with all default/included analyzers and so performance may suffer as more analyzers are included. However, the ability to monitor this will help identify the impact of adding new analyzers. Run should be done of a release build without the debugger attached. @@ -58,6 +58,7 @@ Intel Core i7-8650U CPU 1.90GHz (Kaby Lake R), 1 CPU, 8 logical and 4 physical c | ParseCurrent | 426.9 ms | 18.65 ms | 53.51 ms | 1.00 | 1 | 18000.0000 | 2000.0000 | - | 79.86 MB | ``` -**Notes.** +**Notes.** + - Mean is better than expected. - Allocated memory is worryingly large.