Small improvements on the lot/several rules (#2313)

Author: sylvestre

bugbot/rules/lot_of_cc.py bugbot/rules/several_cc.py

@@ -19,19 +19,28 @@ def has_product_component(self):
         return True
 
     def columns(self):
-        return ["id", "product", "component", "summary", "creation", "last_change"]
+        return [
+            "id",
+            "product",
+            "component",
+            "summary",
+            "creation",
+            "last_change",
+            "cc_count",
+        ]
 
     def handle_bug(self, bug, data):
         bugid = str(bug["id"])
         data[bugid] = {
             "creation": utils.get_human_lag(bug["creation_time"]),
             "last_change": utils.get_human_lag(bug["last_change_time"]),
+            "cc_count": len(bug["cc"]),
         }
         return bug
 
     def get_bz_params(self, date):
         params = {
-            "include_fields": ["creation_time", "last_change_time"],
+            "include_fields": ["creation_time", "last_change_time", "cc"],
             "resolution": "---",
             "f1": "days_elapsed",
             "o1": "lessthan",

bugbot/rules/lot_of_comments.py bugbot/rules/several_comments.py

@@ -16,19 +16,20 @@ def description(self):
         return "Bugs with several dups for the last {} weeks".format(self.nweeks)
 
     def columns(self):
-        return ["id", "summary", "creation", "last_change"]
+        return ["id", "summary", "creation", "last_change", "dupe_count"]
 
     def handle_bug(self, bug, data):
         bugid = str(bug["id"])
         data[bugid] = {
             "creation": utils.get_human_lag(bug["creation_time"]),
             "last_change": utils.get_human_lag(bug["last_change_time"]),
+            "dupe_count": len(bug["duplicates"]),
         }
         return bug
 
     def get_bz_params(self, date):
         params = {
-            "include_fields": ["creation_time", "last_change_time"],
+            "include_fields": ["creation_time", "last_change_time", "duplicates"],
             "resolution": "---",
             "f1": "days_elapsed",
             "o1": "lessthan",

bugbot/rules/several_dups.py

@@ -19,19 +19,28 @@ def has_product_component(self):
         return True
 
     def columns(self):
-        return ["id", "product", "component", "summary", "creation", "last_change"]
+        return [
+            "id",
+            "product",
+            "component",
+            "summary",
+            "creation",
+            "last_change",
+            "votes",
+        ]
 
     def handle_bug(self, bug, data):
         bugid = str(bug["id"])
         data[bugid] = {
             "creation": utils.get_human_lag(bug["creation_time"]),
             "last_change": utils.get_human_lag(bug["last_change_time"]),
+            "votes": bug["votes"],
         }
         return bug
 
     def get_bz_params(self, date):
         params = {
-            "include_fields": ["creation_time", "last_change_time"],
+            "include_fields": ["creation_time", "last_change_time", "votes"],
             "resolution": "---",
             "f1": "days_elapsed",
             "o1": "lessthan",

bugbot/rules/lot_of_see_also.py bugbot/rules/several_see_also.py

@@ -157,23 +157,23 @@
     "additional_receivers": "rm",
     "must_run": ["Mon"]
   },
-  "lot_of_votes": {
+  "several_votes": {
     "weeks_lookup": 3,
     "number_votes": 10,
     "additional_receivers": "rm",
     "must_run": ["Mon"]
   },
-  "lot_of_cc": {
+  "several_cc": {
     "weeks_lookup": 3,
     "number_cc": 50,
     "additional_receivers": "rm",
     "must_run": ["Mon"]
   },
-  "lot_of_comments": {
+  "several_comments": {
     "additional_receivers": "rm",
     "must_run": ["Mon"]
   },
-  "lot_of_see_also": {
+  "several_see_also": {
     "additional_receivers": "rm",
     "must_run": ["Mon"]
   },

bugbot/rules/lot_of_votes.py bugbot/rules/several_votes.py

@@ -45,10 +45,10 @@ class CheckWikiPage:
         "multi_nag.py",
         "multifix_regression.py",
         "several_dups.py",
-        "lot_of_votes.py",
-        "lot_of_cc.py",
-        "lot_of_comments.py",
-        "lot_of_see_also.py",
+        "several_votes.py",
+        "several_cc.py",
+        "several_comments.py",
+        "several_see_also.py",
         "pdfjs_tag_change.py",
         "pdfjs_update.py",
         "leave_open_sec.py",

configs/rules.json

@@ -77,16 +77,16 @@ python -m bugbot.rules.meta_defect --production
 python -m bugbot.rules.several_dups --production
 
 # Bugs with a lot of cc
-python -m bugbot.rules.lot_of_cc --production
+python -m bugbot.rules.several_cc --production
 
 # Bugs with a lot of votes
-python -m bugbot.rules.lot_of_votes --production
+python -m bugbot.rules.several_votes --production
 
 # Bugs with a lot of comments
-python -m bugbot.rules.lot_of_comments --production
+python -m bugbot.rules.several_comments --production
 
 # Bugs with a lot of see also
-python -m bugbot.rules.lot_of_see_also --production
+python -m bugbot.rules.several_see_also --production
 
 # Bug caused several regressions recently reported
 # Pretty rare

scripts/check_rules_on_wiki.py

@@ -7,10 +7,11 @@
             <th>Summary</th>
             <th>Creation</th>
             <th>Last comment</th>
+            <th># of cc</th>
         </tr>
     </thead>
     <tbody>
-        {% for i, (bugid, product, component, summary, creation, last_change) in enumerate(data) -%}
+        {% for i, (bugid, product, component, summary, creation, last_change, cc_count) in enumerate(data) -%}
             <tr {% if i % 2 == 0 %}bgcolor="#E0E0E0"
             {% endif -%}
             >
@@ -21,6 +22,7 @@
             <td>{{ summary | e }}</td>
             <td>{{ creation }}</td>
             <td>{{ last_change }}</td>
+            <td>{{ cc_count }}</td>
         </tr>
     {% endfor -%}
 </tbody>

scripts/cron_run_weekdays.sh

@@ -6,10 +6,11 @@
             <th>Summary</th>
             <th>Creation</th>
             <th>Last comment</th>
+            <th># of dupes</th>
         </tr>
     </thead>
     <tbody>
-        {% for i, (bugid, summary, creation, last_change) in enumerate(data) -%}
+        {% for i, (bugid, summary, creation, last_change, dupe_count) in enumerate(data) -%}
             <tr {% if i % 2 == 0 %}bgcolor="#E0E0E0"
             {% endif -%}
             >
@@ -19,6 +20,7 @@
             <td>{{ summary | e }}</td>
             <td>{{ creation }}</td>
             <td>{{ last_change }}</td>
+            <td>{{ dupe_count }}</td>
         </tr>
     {% endfor -%}
 </tbody>

templates/lot_of_cc.html templates/several_cc.html

@@ -7,10 +7,11 @@
             <th>Summary</th>
             <th>Creation</th>
             <th>Last comment</th>
+            <th># of votes</th>
         </tr>
     </thead>
     <tbody>
-        {% for i, (bugid, product, component, summary, creation, last_change) in enumerate(data) -%}
+        {% for i, (bugid, product, component, summary, creation, last_change, votes) in enumerate(data) -%}
             <tr {% if i % 2 == 0 %}bgcolor="#E0E0E0"
             {% endif -%}
             >
@@ -21,6 +22,7 @@
             <td>{{ summary | e }}</td>
             <td>{{ creation }}</td>
             <td>{{ last_change }}</td>
+            <td>{{ votes }}</td>
         </tr>
     {% endfor -%}
 </tbody>