Autoclear needinfo top crash (#2405)

* Identified where in the code the flags need to be cleared

* Added function to help find needinfo flag requested by BugBot

* Added search to find `needinfo` flag created closest to the comment regarding increasing severity

* Added `comments.creation_date` as an included field when retrieving comments

* Removed date parsing, added exact creation time match check, added support for multiple flags and/or severity comments

* Removed flag

* Removed unnecessary return statements

* Included `flags` and `comments` when retrieving bugs

* Moved the needinfo flag ID collection logic to `handle_bug()`

* Pass the needinfo flags as a list, even if it does not remove `topcrash` keyword

* Changed the conditional for populating the `needinfo_ids` field

* Simplified code

* Cleaned up code

* Replaced `needinfo_ids` with `needinfos_to_remove`

* Replaced a `get()` instance with direct access

* Added flags as a field in `get_bz_params()`

Author: benjaminmah

bugbot/rules/crash_small_volume.py

@@ -122,6 +122,11 @@ def handle_bug(self, bug, data):
             ),
             "keywords_to_remove": keywords_to_remove,
             "signatures": signatures,
+            "needinfos_to_remove": (
+                self.get_needinfo_topcrash_ids(bug)
+                if "topcrash" in keywords_to_remove
+                else []
+            ),
         }
 
         return bug
@@ -180,6 +185,13 @@ def set_autofix(self, bugs):
                     )
                 )
                 autofix["keywords"] = {"remove": list(bug["keywords_to_remove"])}
+                autofix["flags"] = [
+                    {
+                        "id": flag_id,
+                        "status": "X",
+                    }
+                    for flag_id in bug["needinfos_to_remove"]
+                ]
 
             if not bug["ignore_severity"] and all(
                 signature in low_volume_signatures for signature in bug["signatures"]
@@ -202,6 +214,31 @@ def set_autofix(self, bugs):
                 }
                 self.autofix_changes[bugid] = autofix
 
+    def get_needinfo_topcrash_ids(self, bug: dict) -> list[int]:
+        """Get the IDs of the needinfo flags requested by the bot regarding increasing the severity."""
+        needinfo_flags = [
+            flag
+            for flag in bug["flags"]
+            if flag["name"] == "needinfo" and flag["requestee"] == History.BOT
+        ]
+
+        needinfo_comment = (
+            "could you consider increasing the severity of this top-crash bug?"
+        )
+
+        severity_comment_times = [
+            comment["creation_time"]
+            for comment in bug["comments"]
+            if comment["creator"] == History.BOT
+            and needinfo_comment in comment["raw_text"]
+        ]
+
+        return [
+            flag["id"]
+            for flag in needinfo_flags
+            if flag["creation_date"] in severity_comment_times
+        ]
+
     @staticmethod
     def _has_severity_downgrade_comment(bug):
         for comment in reversed(bug["comments"]):
@@ -250,7 +287,9 @@ def get_bz_params(self, date):
             "cf_crash_signature",
             "comments.raw_text",
             "comments.creator",
+            "comments.creation_time",
             "history",
+            "flags",
         ]
         params = {
             "include_fields": fields,