Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7.0.4 release breaks windows #163

Closed
achingbrain opened this issue Nov 7, 2024 · 3 comments · Fixed by #162
Closed

7.0.4 release breaks windows #163

achingbrain opened this issue Nov 7, 2024 · 3 comments · Fixed by #162

Comments

@achingbrain
Copy link

achingbrain commented Nov 7, 2024

The change in this commit: 5ff3a07#diff-7b6c860fc27e47e0176b07d4bbb28c750651fe1fcf59bd207e9eaa7c47dab0ddL26 breaks windows.

I'm trying to run npm run test via execa (which uses this module) and it now fails with:

Unknown command: "run$1$1"

E.g.: https://github.com/libp2p/js-libp2p/actions/runs/11722923623/job/32653668053

Undoing the change from the commit above makes everything start working again.

Refs: sindresorhus/execa#578

@satazor
Copy link
Contributor

satazor commented Nov 7, 2024

#162 should fix this, just waiting for the tests to run

@satazor
Copy link
Contributor

satazor commented Nov 7, 2024

[email protected]

@achingbrain
Copy link
Author

The fix works, thanks for the speedy resolution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants