Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUGGESTION: Rename amount to amountInCents #221

Open
zbruhnke opened this issue Jul 6, 2022 · 2 comments
Open

SUGGESTION: Rename amount to amountInCents #221

zbruhnke opened this issue Jul 6, 2022 · 2 comments
Labels
bug Something isn't working enhancement New feature or request
Milestone

Comments

@zbruhnke
Copy link

zbruhnke commented Jul 6, 2022

Wire Version: Release v0.9.0-rc1

What were you trying to do?

Send a wire for $1200

What did you expect to see?

a wire for $1200

What did you see?

a wire for $12

How can we reproduce the problem?

with the name of the field not being clear it would be easy for someone to submit the wrong amount, I realize this is a nitpick so I added it to its own issue, its mostly just that consistency in naming would help here and this would be much more explicit

@adamdecaf adamdecaf added bug Something isn't working enhancement New feature or request labels Jul 6, 2022
@adamdecaf
Copy link
Member

When writing these libraries we stuck to the names in specifications, however I agree this is a tricky one to catch. The ACH library calls it "amount" as that's what Nacha calls it as well.

I'm indifferent, but changing this would break the API (in a helpful way).

@adamdecaf adamdecaf added this to the v0.10.0 milestone Jul 6, 2022
@adamdecaf
Copy link
Member

@atonks2 thoughts? I added it to v0.10.0 if we want to accept this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants