Skip to content

Commit 6a2ff3f

Browse files
htynknsnicoll
authored andcommitted
Upgrade elasticsearch to 2.2.0
Closes spring-projectsgh-5443
1 parent c98b809 commit 6a2ff3f

File tree

7 files changed

+11
-35
lines changed

7 files changed

+11
-35
lines changed

spring-boot-actuator/src/test/java/org/springframework/boot/actuate/autoconfigure/HealthIndicatorAutoConfigurationTests.java

-4
Original file line numberDiff line numberDiff line change
@@ -393,8 +393,6 @@ public void notJmsHealthIndicator() {
393393
@Test
394394
public void elasticSearchHealthIndicator() {
395395
EnvironmentTestUtils.addEnvironment(this.context,
396-
"spring.data.elasticsearch.properties.path.data:target/data",
397-
"spring.data.elasticsearch.properties.path.logs:target/logs",
398396
"management.health.diskspace.enabled:false");
399397
this.context.register(ElasticsearchAutoConfiguration.class,
400398
ManagementServerProperties.class, HealthIndicatorAutoConfiguration.class);
@@ -411,8 +409,6 @@ public void elasticSearchHealthIndicator() {
411409
public void notElasticSearchHealthIndicator() {
412410
EnvironmentTestUtils.addEnvironment(this.context,
413411
"management.health.elasticsearch.enabled:false",
414-
"spring.data.elasticsearch.properties.path.data:target/data",
415-
"spring.data.elasticsearch.properties.path.logs:target/logs",
416412
"management.health.diskspace.enabled:false");
417413
this.context.register(ElasticsearchAutoConfiguration.class,
418414
ManagementServerProperties.class, HealthIndicatorAutoConfiguration.class);

spring-boot-actuator/src/test/java/org/springframework/boot/actuate/health/ElasticsearchHealthIndicatorTests.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -23,13 +23,13 @@
2323
import org.elasticsearch.ElasticsearchTimeoutException;
2424
import org.elasticsearch.action.admin.cluster.health.ClusterHealthRequest;
2525
import org.elasticsearch.action.admin.cluster.health.ClusterHealthResponse;
26-
import org.elasticsearch.action.admin.cluster.health.ClusterHealthStatus;
2726
import org.elasticsearch.action.support.PlainActionFuture;
2827
import org.elasticsearch.client.AdminClient;
2928
import org.elasticsearch.client.Client;
3029
import org.elasticsearch.client.ClusterAdminClient;
3130
import org.elasticsearch.cluster.ClusterState;
3231
import org.elasticsearch.cluster.block.ClusterBlocks;
32+
import org.elasticsearch.cluster.health.ClusterHealthStatus;
3333
import org.elasticsearch.cluster.node.DiscoveryNodes;
3434
import org.elasticsearch.cluster.routing.RoutingTable;
3535
import org.junit.Before;
@@ -176,9 +176,9 @@ private StubClusterHealthResponse() {
176176

177177
private StubClusterHealthResponse(ClusterHealthStatus status) {
178178
super("test-cluster", new String[0],
179-
new ClusterState(null, 0, null, RoutingTable.builder().build(),
179+
new ClusterState(null, 0, null, null, RoutingTable.builder().build(),
180180
DiscoveryNodes.builder().build(),
181-
ClusterBlocks.builder().build(), null));
181+
ClusterBlocks.builder().build(), null, false));
182182
this.status = status;
183183
}
184184

spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/data/elasticsearch/ElasticsearchAutoConfiguration.java

+4-2
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616

1717
package org.springframework.boot.autoconfigure.data.elasticsearch;
1818

19+
import java.io.File;
1920
import java.util.Collections;
2021
import java.util.LinkedHashMap;
2122
import java.util.Map;
@@ -26,7 +27,7 @@
2627
import org.elasticsearch.client.Client;
2728
import org.elasticsearch.client.transport.TransportClient;
2829
import org.elasticsearch.common.lease.Releasable;
29-
import org.elasticsearch.common.settings.ImmutableSettings;
30+
import org.elasticsearch.common.settings.Settings;
3031
import org.elasticsearch.node.Node;
3132
import org.elasticsearch.node.NodeBuilder;
3233

@@ -62,6 +63,7 @@ public class ElasticsearchAutoConfiguration implements DisposableBean {
6263
Map<String, String> defaults = new LinkedHashMap<String, String>();
6364
defaults.put("http.enabled", String.valueOf(false));
6465
defaults.put("node.local", String.valueOf(true));
66+
defaults.put("path.home", new File(System.getProperty("java.io.tmpdir"), "elastic-home").getAbsolutePath());
6567
DEFAULTS = Collections.unmodifiableMap(defaults);
6668
}
6769

@@ -95,7 +97,7 @@ private Client createClient() throws Exception {
9597
}
9698

9799
private Client createNodeClient() throws Exception {
98-
ImmutableSettings.Builder settings = ImmutableSettings.settingsBuilder();
100+
Settings.Builder settings = Settings.settingsBuilder();
99101
for (Map.Entry<String, String> entry : DEFAULTS.entrySet()) {
100102
if (!this.properties.getProperties().containsKey(entry.getKey())) {
101103
settings.put(entry.getKey(), entry.getValue());

spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/data/elasticsearch/ElasticsearchAutoConfigurationTests.java

+2-8
Original file line numberDiff line numberDiff line change
@@ -56,9 +56,7 @@ public void close() {
5656
public void createNodeClientWithDefaults() {
5757
this.context = new AnnotationConfigApplicationContext();
5858
EnvironmentTestUtils.addEnvironment(this.context,
59-
"spring.data.elasticsearch.properties.foo.bar:baz",
60-
"spring.data.elasticsearch.properties.path.data:target/data",
61-
"spring.data.elasticsearch.properties.path.logs:target/logs");
59+
"spring.data.elasticsearch.properties.foo.bar:baz");
6260
this.context.register(PropertyPlaceholderAutoConfiguration.class,
6361
ElasticsearchAutoConfiguration.class);
6462
this.context.refresh();
@@ -74,8 +72,6 @@ public void createNodeClientWithOverrides() {
7472
this.context = new AnnotationConfigApplicationContext();
7573
EnvironmentTestUtils.addEnvironment(this.context,
7674
"spring.data.elasticsearch.properties.foo.bar:baz",
77-
"spring.data.elasticsearch.properties.path.data:target/data",
78-
"spring.data.elasticsearch.properties.path.logs:target/logs",
7975
"spring.data.elasticsearch.properties.node.local:false",
8076
"spring.data.elasticsearch.properties.node.data:true",
8177
"spring.data.elasticsearch.properties.http.enabled:true");
@@ -108,9 +104,7 @@ public void createTransportClient() throws Exception {
108104
// a port and check the exception
109105
this.context = new AnnotationConfigApplicationContext();
110106
EnvironmentTestUtils.addEnvironment(this.context,
111-
"spring.data.elasticsearch.cluster-nodes:localhost",
112-
"spring.data.elasticsearch.properties.path.data:target/data",
113-
"spring.data.elasticsearch.properties.path.logs:target/logs");
107+
"spring.data.elasticsearch.cluster-nodes:localhost");
114108
this.context.register(PropertyPlaceholderAutoConfiguration.class,
115109
ElasticsearchAutoConfiguration.class);
116110
this.thrown.expect(BeanCreationException.class);

spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/data/elasticsearch/ElasticsearchRepositoriesAutoConfigurationTests.java

-10
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@
2626
import org.springframework.boot.autoconfigure.data.elasticsearch.city.City;
2727
import org.springframework.boot.autoconfigure.data.elasticsearch.city.CityRepository;
2828
import org.springframework.boot.autoconfigure.data.empty.EmptyDataPackage;
29-
import org.springframework.boot.test.util.EnvironmentTestUtils;
3029
import org.springframework.context.annotation.AnnotationConfigApplicationContext;
3130
import org.springframework.context.annotation.Configuration;
3231
import org.springframework.data.elasticsearch.repository.config.EnableElasticsearchRepositories;
@@ -50,7 +49,6 @@ public void close() {
5049
@Test
5150
public void testDefaultRepositoryConfiguration() throws Exception {
5251
this.context = new AnnotationConfigApplicationContext();
53-
addElasticsearchProperties(this.context);
5452
this.context.register(TestConfiguration.class,
5553
ElasticsearchAutoConfiguration.class,
5654
ElasticsearchRepositoriesAutoConfiguration.class,
@@ -64,7 +62,6 @@ public void testDefaultRepositoryConfiguration() throws Exception {
6462
@Test
6563
public void testNoRepositoryConfiguration() throws Exception {
6664
this.context = new AnnotationConfigApplicationContext();
67-
addElasticsearchProperties(this.context);
6865
this.context.register(EmptyConfiguration.class,
6966
ElasticsearchAutoConfiguration.class,
7067
ElasticsearchRepositoriesAutoConfiguration.class,
@@ -77,7 +74,6 @@ public void testNoRepositoryConfiguration() throws Exception {
7774
@Test
7875
public void doesNotTriggerDefaultRepositoryDetectionIfCustomized() {
7976
this.context = new AnnotationConfigApplicationContext();
80-
addElasticsearchProperties(this.context);
8177
this.context.register(CustomizedConfiguration.class,
8278
ElasticsearchAutoConfiguration.class,
8379
ElasticsearchRepositoriesAutoConfiguration.class,
@@ -87,12 +83,6 @@ public void doesNotTriggerDefaultRepositoryDetectionIfCustomized() {
8783
assertThat(this.context.getBean(CityElasticsearchDbRepository.class)).isNotNull();
8884
}
8985

90-
private void addElasticsearchProperties(AnnotationConfigApplicationContext context) {
91-
EnvironmentTestUtils.addEnvironment(context,
92-
"spring.data.elasticsearch.properties.path.data:target/data",
93-
"spring.data.elasticsearch.properties.path.logs:target/logs");
94-
}
95-
9686
@Configuration
9787
@TestAutoConfigurationPackage(City.class)
9888
protected static class TestConfiguration {

spring-boot-dependencies/pom.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@
7070
<embedded-mongo.version>1.50.2</embedded-mongo.version>
7171
<flyway.version>3.2.1</flyway.version>
7272
<freemarker.version>2.3.23</freemarker.version>
73-
<elasticsearch.version>1.7.5</elasticsearch.version>
73+
<elasticsearch.version>2.2.0</elasticsearch.version>
7474
<gemfire.version>8.2.0</gemfire.version>
7575
<glassfish-el.version>3.0.0</glassfish-el.version>
7676
<gradle.version>1.12</gradle.version>

spring-boot-samples/spring-boot-sample-data-elasticsearch/src/test/java/sample/data/elasticsearch/SampleElasticsearchApplicationTests.java

+1-7
Original file line numberDiff line numberDiff line change
@@ -33,19 +33,13 @@
3333
* @author Artur Konczak
3434
*/
3535
public class SampleElasticsearchApplicationTests {
36-
37-
private static final String[] PROPERTIES = {
38-
"spring.data.elasticsearch.properties.path.data:target/data",
39-
"spring.data.elasticsearch.properties.path.logs:target/logs" };
40-
4136
@Rule
4237
public OutputCapture outputCapture = new OutputCapture();
4338

4439
@Test
4540
public void testDefaultSettings() throws Exception {
4641
try {
47-
new SpringApplicationBuilder(SampleElasticsearchApplication.class)
48-
.properties(PROPERTIES).run();
42+
new SpringApplicationBuilder(SampleElasticsearchApplication.class).run();
4943
}
5044
catch (IllegalStateException ex) {
5145
if (serverNotRunning(ex)) {

0 commit comments

Comments
 (0)