-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename gem to rspec-mongoid #150
Comments
Or maybe with now with the mongoid5 changes is a good hour to add a deprecated message to the old require .rb file. #149 |
Hey @nofxx thanks to point it. Currently this gem is practically unmaintained. because me and @evansagge are not working with mongo/mongoid anymore. If you could to send this PR with bump version I would appreciate. Valeu @nofxx ! 👍 |
Change gem naming according to issue #150
@nofxx @90yukke Is this gem adding rspec functionality to mongoid, or is it adding mongoid functionality to rspec? I would think it's the latter and in which case, the naming (per the rubygems guide) would actually be 'rspec-mongoid'. And as a side question, should we name gems for the technology support being added or the gem support being added when the names differ. For example, this gem. Should it be 'rspec-mongoid' after the gem, or 'rspec-mongodb' after the technology? Your thoughts? |
@vidkun I agree that 'rspec-mongoid' fits better. @rodrigopinto @evansagge What do you think guys? Does it make sense to rename github organisation/gem right now? I can add deprecation message to "mongoid-rspec" gem and start new one within this organisation. |
Had the same issue the other day. Same scenario: @vidkun About the mongoid/mongodb keep it |
@nofxx Cool. That question was more as a general rule which is better. Your answer still makes sense though. Thanks. |
If someone cares about this a lot I can help with the change before we release the next version via #193. |
Always feels pedant when I open this issue on projects, but it's for the greater good (so I think):
http://guides.rubygems.org/name-your-gem/
It's a really minor issue to fix this way:
Keeps old require,
require 'mongoid-rspec'
no need to ppl change their code.But the correct
require: 'mongoid/rspec'
will now work too.The text was updated successfully, but these errors were encountered: