Remove manual dirty _id check when updating a model #3329
Merged
+42
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
requested changes
Mar 31, 2025
There was a problem hiding this comment.
As a simpler fix, we can remove the exception in the Query\Builder::update method, and let the MongoDB server throw an exception itself when someone tries to update the _id field.
laravel-mongodb/src/Query/Builder.php
Lines 786 to 791 in 730a2ac
GromNaN
force-pushed
the
fix/created-event-dirty-save
branch
from
d3778f0 to
addd93f
Compare
GromNaN
approved these changes
Mar 31, 2025
GromNaN
changed the title
GromNaN
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where calling
save()orsaveQuietly()inside a model'screatedevent throws:InvalidArgumentException: Cannot update "id" fieldRelated Issue
Closes #3326
Background
After inserting the model, Laravel's internal state still sees
_idas dirty — sosave()tries to update it again, which MongoDB doesn't allow.Fix
The explicit check for dirty _id has been removed, and the behavior now relies on MongoDB itself to throw an error if _id is mutated.
Checklist