-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Have support for JDK 11 #5
Comments
https://github.com/newrelic/newrelic-jfr-core does something similar in order to support JDK 11 (non-streaming use case) |
Hi Gunnar! We just started producing JFR events in Hibernate and have been using JFRUnit for testing. But we still baseline on Java 11, so this limitation is not ideal for us. I'd be willing to take a look at supporting Java 11. Any pointers on where to start in your code? |
Hey @sebersole, long time, no see :)
Woot, how cool is that!
Gotcha. Have you considered requiring a newer LTS (17, 21) for your own build, while still emitting Java 11 compatible build artifacts? It's quite comfortably doable these days, so that would be my recommendation. Unless anything stops you from building on Java 17+.
References to That said, all in all, my recommendation, as stated above, would be exploring whether you can move your build to Java 17 or newer. With Java 21 being released as another LTS just lust month, my appetite for supporting LTS-2 is starting to diminish somewhat. |
By dumping to a recording file and parsing that, JDK 11 might be a sufficient basis for an alternative mode of operation.
The text was updated successfully, but these errors were encountered: