Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExpectedEvent.with should support all primitive types #20

Open
marcphilipp opened this issue Dec 23, 2020 · 1 comment
Open

ExpectedEvent.with should support all primitive types #20

marcphilipp opened this issue Dec 23, 2020 · 1 comment

Comments

@marcphilipp
Copy link

In addition to String and Duration, ExpectedEvent.with should support (at least) all primitive value types. Currently, calling with("name", 1) yields a IllegalArgumentException: https://github.com/gunnarmorling/jfrunit/blob/3848a086f60474733a7b3cc73dd0ecc95a856a55/src/main/java/dev/morling/jfrunit/ExpectedEvent.java#L82
@gunnarmorling
Copy link
Member

Definitely, all supported JFr event attribute types should be supported. PRs welcome of course :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gunnarmorling @marcphilipp