From 4c98b30b6021ec212ab1452a53b99f1426cad0e3 Mon Sep 17 00:00:00 2001
From: Oleksandr Fediashov <olfedias@microsoft.com>
Date: Wed, 24 Nov 2021 09:17:13 +0100
Subject: [PATCH] chore: run migration for @fluentui/react-provider (#20726)

* chore: run migration for @fluentui/react-provider

* Change files
---
 ...-56c89bdc-0547-4d22-ba0a-c2e0085e613b.json |  7 +++++
 packages/react-provider/.npmignore            |  1 -
 packages/react-provider/.storybook/main.js    |  6 ++--
 packages/react-provider/.storybook/preview.js |  4 +++
 .../react-provider/.storybook/tsconfig.json   |  7 +++--
 .../config/api-extractor.local.json           |  2 +-
 packages/react-provider/jest.config.js        |  2 +-
 packages/react-provider/package.json          |  5 ++--
 .../stories/FluentProviderDefault.stories.tsx |  7 ++---
 .../stories/FluentProviderFrame.stories.tsx   |  5 ++--
 packages/react-provider/tsconfig.json         | 29 ++++++++++++-------
 packages/react-provider/tsconfig.lib.json     | 20 +++++++++++++
 packages/react-provider/tsconfig.spec.json    |  9 ++++++
 13 files changed, 76 insertions(+), 28 deletions(-)
 create mode 100644 change/@fluentui-react-provider-56c89bdc-0547-4d22-ba0a-c2e0085e613b.json
 create mode 100644 packages/react-provider/tsconfig.lib.json
 create mode 100644 packages/react-provider/tsconfig.spec.json

diff --git a/change/@fluentui-react-provider-56c89bdc-0547-4d22-ba0a-c2e0085e613b.json b/change/@fluentui-react-provider-56c89bdc-0547-4d22-ba0a-c2e0085e613b.json
new file mode 100644
index 0000000000000..4fc1676753a61
--- /dev/null
+++ b/change/@fluentui-react-provider-56c89bdc-0547-4d22-ba0a-c2e0085e613b.json
@@ -0,0 +1,7 @@
+{
+  "type": "none",
+  "comment": "update tooling configs",
+  "packageName": "@fluentui/react-provider",
+  "email": "olfedias@microsoft.com",
+  "dependentChangeType": "none"
+}
diff --git a/packages/react-provider/.npmignore b/packages/react-provider/.npmignore
index fa2d3a7f5111c..e719afb921bc9 100644
--- a/packages/react-provider/.npmignore
+++ b/packages/react-provider/.npmignore
@@ -1,4 +1,3 @@
-.cache/
 .storybook/
 .vscode/
 bundle-size/
diff --git a/packages/react-provider/.storybook/main.js b/packages/react-provider/.storybook/main.js
index ec377d98606fa..18a60b265c2cf 100644
--- a/packages/react-provider/.storybook/main.js
+++ b/packages/react-provider/.storybook/main.js
@@ -1,12 +1,14 @@
 const rootMain = require('../../../.storybook/main');
 
-module.exports = /** @type {Pick<import('../../../.storybook/main').StorybookConfig,'addons'|'stories'|'webpackFinal'>} */ ({
+module.exports = /** @type {Omit<import('../../../.storybook/main'), 'typescript'|'babel'>} */ ({
+  ...rootMain,
   stories: [...rootMain.stories, '../src/**/*.stories.mdx', '../src/**/*.stories.@(ts|tsx)'],
   addons: [...rootMain.addons],
   webpackFinal: (config, options) => {
     const localConfig = { ...rootMain.webpackFinal(config, options) };
 
+    // add your own webpack tweaks if needed
+
     return localConfig;
   },
-  previewHead: rootMain.previewHead,
 });
diff --git a/packages/react-provider/.storybook/preview.js b/packages/react-provider/.storybook/preview.js
index b52409294c330..10fd98d02c945 100644
--- a/packages/react-provider/.storybook/preview.js
+++ b/packages/react-provider/.storybook/preview.js
@@ -1,3 +1,7 @@
 import * as rootPreview from '../../../.storybook/preview';
 
+/** @type {typeof rootPreview.decorators} */
 export const decorators = [...rootPreview.decorators];
+
+/** @type {typeof rootPreview.parameters} */
+export const parameters = { ...rootPreview.parameters };
diff --git a/packages/react-provider/.storybook/tsconfig.json b/packages/react-provider/.storybook/tsconfig.json
index 3bd9adcd2ee05..29aa16f2f178f 100644
--- a/packages/react-provider/.storybook/tsconfig.json
+++ b/packages/react-provider/.storybook/tsconfig.json
@@ -1,9 +1,10 @@
 {
   "extends": "../tsconfig.json",
   "compilerOptions": {
+    "outDir": "",
     "allowJs": true,
-    "checkJs": true
+    "checkJs": true,
+    "types": ["static-assets", "environment", "inline-style-expand-shorthand", "storybook__addons"]
   },
-  "exclude": ["../**/*.test.ts", "../**/*.test.js", "../**/*.test.tsx", "../**/*.test.jsx"],
-  "include": ["../src/**/*", "*.js"]
+  "include": ["../src/**/*.stories.ts", "../src/**/*.stories.tsx", "*.js"]
 }
diff --git a/packages/react-provider/config/api-extractor.local.json b/packages/react-provider/config/api-extractor.local.json
index c2ea401c1c368..7974a129e8a33 100644
--- a/packages/react-provider/config/api-extractor.local.json
+++ b/packages/react-provider/config/api-extractor.local.json
@@ -1,5 +1,5 @@
 {
   "$schema": "https://developer.microsoft.com/json-schemas/api-extractor/v7/api-extractor.schema.json",
   "extends": "./api-extractor.json",
-  "mainEntryPointFilePath": "<projectFolder>/dist/<unscopedPackageName>/src/index.d.ts"
+  "mainEntryPointFilePath": "<projectFolder>/dist/packages/<unscopedPackageName>/src/index.d.ts"
 }
diff --git a/packages/react-provider/jest.config.js b/packages/react-provider/jest.config.js
index eef1bdd5d9269..9ecbd359ec1ae 100644
--- a/packages/react-provider/jest.config.js
+++ b/packages/react-provider/jest.config.js
@@ -8,7 +8,7 @@ module.exports = {
   preset: '../../jest.preset.js',
   globals: {
     'ts-jest': {
-      tsConfig: '<rootDir>/tsconfig.json',
+      tsConfig: '<rootDir>/tsconfig.spec.json',
       diagnostics: false,
     },
   },
diff --git a/packages/react-provider/package.json b/packages/react-provider/package.json
index f0ebf52ac5cb0..fe1f824835a94 100644
--- a/packages/react-provider/package.json
+++ b/packages/react-provider/package.json
@@ -20,9 +20,10 @@
     "just": "just-scripts",
     "lint": "just-scripts lint",
     "docs": "api-extractor run --config=config/api-extractor.local.json --local",
-    "build:local": "tsc -p . --module esnext --emitDeclarationOnly && node ../../scripts/typescript/normalize-import --output dist/react-provider/src && yarn docs",
+    "build:local": "tsc -p ./tsconfig.lib.json --module esnext --emitDeclarationOnly && node ../../scripts/typescript/normalize-import --output ./dist/packages/react-provider/src && yarn docs",
     "storybook": "start-storybook",
-    "start": "yarn storybook"
+    "start": "yarn storybook",
+    "type-check": "tsc -b tsconfig.json"
   },
   "devDependencies": {
     "@fluentui/babel-make-styles": "9.0.0-beta.3",
diff --git a/packages/react-provider/src/stories/FluentProviderDefault.stories.tsx b/packages/react-provider/src/stories/FluentProviderDefault.stories.tsx
index 518f8e5c16f25..597c19dedc9ec 100644
--- a/packages/react-provider/src/stories/FluentProviderDefault.stories.tsx
+++ b/packages/react-provider/src/stories/FluentProviderDefault.stories.tsx
@@ -1,10 +1,9 @@
 import * as React from 'react';
+import { Button } from '@fluentui/react-button';
 import { makeStyles } from '@fluentui/react-make-styles';
 import { webLightTheme, teamsLightTheme, teamsDarkTheme } from '@fluentui/react-theme';
-// eslint-disable-next-line @typescript-eslint/ban-ts-comment
-// @ts-ignore
-import { Button } from '@fluentui/react-button';
-import { FluentProvider } from '../FluentProvider'; // codesandbox-dependency: @fluentui/react-components ^9.0.0-beta
+
+import { FluentProvider } from '../FluentProvider';
 
 const useStyles = makeStyles({
   button: {
diff --git a/packages/react-provider/src/stories/FluentProviderFrame.stories.tsx b/packages/react-provider/src/stories/FluentProviderFrame.stories.tsx
index 5d097988828ce..a6752523036ad 100644
--- a/packages/react-provider/src/stories/FluentProviderFrame.stories.tsx
+++ b/packages/react-provider/src/stories/FluentProviderFrame.stories.tsx
@@ -1,10 +1,9 @@
 import * as React from 'react';
 import * as ReactDOM from 'react-dom';
-// eslint-disable-next-line @typescript-eslint/ban-ts-comment
-// @ts-ignore
 import { Button } from '@fluentui/react-button';
 import { createDOMRenderer, makeStyles, RendererProvider } from '@fluentui/react-make-styles';
-import { FluentProvider } from '../FluentProvider'; // codesandbox-dependency: @fluentui/react-components ^9.0.0-beta
+
+import { FluentProvider } from '../FluentProvider';
 
 const useExampleStyles = makeStyles({
   button: {
diff --git a/packages/react-provider/tsconfig.json b/packages/react-provider/tsconfig.json
index d0ba217d5e49b..affceae1828ae 100644
--- a/packages/react-provider/tsconfig.json
+++ b/packages/react-provider/tsconfig.json
@@ -1,18 +1,25 @@
 {
   "extends": "../../tsconfig.base.json",
-  "include": ["src"],
   "compilerOptions": {
     "target": "ES2019",
-    "module": "CommonJS",
-    "lib": ["ES2019", "DOM"],
-    "outDir": "dist",
-    "jsx": "react",
-    "declaration": true,
-    "experimentalDecorators": true,
+    "noEmit": true,
+    "isolatedModules": true,
     "importHelpers": true,
+    "jsx": "react",
     "noUnusedLocals": true,
-    "preserveConstEnums": true,
-    "types": ["jest", "custom-global", "inline-style-expand-shorthand"],
-    "isolatedModules": true
-  }
+    "preserveConstEnums": true
+  },
+  "include": [],
+  "files": [],
+  "references": [
+    {
+      "path": "./tsconfig.lib.json"
+    },
+    {
+      "path": "./tsconfig.spec.json"
+    },
+    {
+      "path": "./.storybook/tsconfig.json"
+    }
+  ]
 }
diff --git a/packages/react-provider/tsconfig.lib.json b/packages/react-provider/tsconfig.lib.json
new file mode 100644
index 0000000000000..b83999c31f8a3
--- /dev/null
+++ b/packages/react-provider/tsconfig.lib.json
@@ -0,0 +1,20 @@
+{
+  "extends": "./tsconfig.json",
+  "compilerOptions": {
+    "noEmit": false,
+    "lib": ["ES2019", "dom"],
+    "outDir": "dist",
+    "declaration": true,
+    "types": ["static-assets", "environment", "inline-style-expand-shorthand"]
+  },
+  "exclude": [
+    "./src/common/**",
+    "**/*.spec.ts",
+    "**/*.spec.tsx",
+    "**/*.test.ts",
+    "**/*.test.tsx",
+    "**/*.stories.ts",
+    "**/*.stories.tsx"
+  ],
+  "include": ["./src/**/*.ts", "./src/**/*.tsx"]
+}
diff --git a/packages/react-provider/tsconfig.spec.json b/packages/react-provider/tsconfig.spec.json
new file mode 100644
index 0000000000000..28fa5226de420
--- /dev/null
+++ b/packages/react-provider/tsconfig.spec.json
@@ -0,0 +1,9 @@
+{
+  "extends": "./tsconfig.json",
+  "compilerOptions": {
+    "module": "CommonJS",
+    "outDir": "dist",
+    "types": ["jest", "node", "inline-style-expand-shorthand"]
+  },
+  "include": ["**/*.spec.ts", "**/*.spec.tsx", "**/*.test.ts", "**/*.test.tsx", "**/*.d.ts"]
+}