Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Incorrect default argument and KeyError for llama #62

Open
ZisIsNotZis opened this issue Mar 4, 2025 · 0 comments
Open

[Bug] Incorrect default argument and KeyError for llama #62

ZisIsNotZis opened this issue Mar 4, 2025 · 0 comments

Comments

@ZisIsNotZis
Copy link

ZisIsNotZis commented Mar 4, 2025

Currently, if kv_quant_granularity not given:

from omniserve import LLMEngine, EngineArgs
M = 'mit-han-lab/Llama-3-8B-Instruct-QServe-g128'
M = LLMEngine.from_engine_args(EngineArgs(M, ifb_mode=1, precision='w4a8kv4', quant_path=M))

results in

NotImplementedError: Unsupported kv_quant_granularity None

After adding one:

from omniserve import LLMEngine, EngineArgs
M = 'mit-han-lab/Llama-3-8B-Instruct-QServe-g128'
M = LLMEngine.from_engine_args(EngineArgs(M, ifb_mode=1, precision='w4a8kv4', quant_path=M, kv_quant_granularity='per_tensor'))

still results in

KeyError: 'model.layers.0.self_attn.qkv_proj.s2_scales'

I tried llama and mistral, non of them work. Maybe the model uploaded and readme are already too outdated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant