fix: SDL_LoadGIF() check for palette not null

miniupnp · miniupnp · commit cfbedecfeca6 · 2025-03-16T23:53:22.000+01:00
fixes #48
diff --git a/ngiflibSDL.c b/ngiflibSDL.c
@@ -87,11 +87,14 @@ SDL_Surface * SDL_LoadGIF(const char * file)
 	{
 		SDL_SetColorKey(surface, SDL_SRCCOLORKEY, gif->cur_img->gce.transparent_color);
 	}
-	for(i=0; i<gif->ncolors; i++)
+	if (gif->palette != NULL)
 	{
-		surface->format->palette->colors[i].r = gif->palette[i].r;
-		surface->format->palette->colors[i].g = gif->palette[i].g;
-		surface->format->palette->colors[i].b = gif->palette[i].b;
+		for(i=0; i<gif->ncolors; i++)
+		{
+			surface->format->palette->colors[i].r = gif->palette[i].r;
+			surface->format->palette->colors[i].g = gif->palette[i].g;
+			surface->format->palette->colors[i].b = gif->palette[i].b;
+		}
 	}
 	if(gif->width > 0 && gif->height > 0)
 	{

Original file line number	Diff line number	Diff line change
`@@ -87,11 +87,14 @@ SDL_Surface * SDL_LoadGIF(const char * file)`
`87`	`87`	`{`
`88`	`88`	`SDL_SetColorKey(surface, SDL_SRCCOLORKEY, gif->cur_img->gce.transparent_color);`
`89`	`89`	`}`
`90`		`- for(i=0; i<gif->ncolors; i++)`
	`90`	`+ if (gif->palette != NULL)`
`91`	`91`	`{`
`92`		`- surface->format->palette->colors[i].r = gif->palette[i].r;`
`93`		`- surface->format->palette->colors[i].g = gif->palette[i].g;`
`94`		`- surface->format->palette->colors[i].b = gif->palette[i].b;`
	`92`	`+ for(i=0; i<gif->ncolors; i++)`
	`93`	`+ {`
	`94`	`+ surface->format->palette->colors[i].r = gif->palette[i].r;`
	`95`	`+ surface->format->palette->colors[i].g = gif->palette[i].g;`
	`96`	`+ surface->format->palette->colors[i].b = gif->palette[i].b;`
	`97`	`+ }`
`95`	`98`	`}`
`96`	`99`	`if(gif->width > 0 && gif->height > 0)`
`97`	`100`	`{`