Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: 类型注解错误 #2566

Open
1 task done
elijahxb opened this issue Jan 15, 2025 · 0 comments
Open
1 task done

[Bug]: 类型注解错误 #2566

elijahxb opened this issue Jan 15, 2025 · 0 comments
Labels
kind/bug Something isn't working

Comments

@elijahxb
Copy link

elijahxb commented Jan 15, 2025

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

pymilvus 2.3.4升级到2.5.3版本发现修改collection属性方法变化,而该方法的参数注解存在错误,容易误导开发者。

Expected Behavior

No response

Steps/Code To Reproduce behavior

https://github.com/milvus-io/pymilvus/blob/08fe03da166e77e6529fb9d868550bbb2ac9131b/pymilvus/client/grpc_handler.py#L324
alter_collection_properties中参数properties类型注解是List,而最终校验的时候要求是dict类型。

[def is_legal_collection_properties(properties: Any) -> bool:](https://github.com/milvus-io/pymilvus/blob/08fe03da166e77e6529fb9d868550bbb2ac9131b/pymilvus/client/check.py#L289)

Environment details

- Hardware/Softward conditions (OS, CPU, GPU, Memory): Mac Inter Chip/ 16G
- Method of installation (source):
- Milvus version (v2.5.3):
- Milvus configuration (Settings you made in `server_config.yaml`):

Anything else?

No response

@elijahxb elijahxb added the kind/bug Something isn't working label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant