Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interval name is not standard #47

Open
sugizo opened this issue Sep 5, 2020 · 4 comments
Open

interval name is not standard #47

sugizo opened this issue Sep 5, 2020 · 4 comments
Labels

Comments

@sugizo
Copy link

sugizo commented Sep 5, 2020

the 8 semitone :
in whole tone scale is written as A5 stand for augmented fifth
in diatonic is written as m6 stand for minor sixth

yet the semitone is same, but the name is not standard, perhaps you can have a button to choose the interval name
Minor, major, or perfect intervals
and
Augmented or diminished intervals

ref:
https://en.wikipedia.org/wiki/Interval_(music)#Main_intervals

thanks

@mikehadlow
Copy link
Owner

So guitar dashboard is driven by an algorithm that calculates the names of notes and intervals based on a formula that works quite well for 7 note scales, but falls down on scales with different number of notes. I think this would require some thought and changes to the algorithm, so not something that will happen very quickly I'm afraid.

@sugizo
Copy link
Author

sugizo commented Sep 7, 2020

seems misunderstood about this, all about the semitone naming either using :
Minor, major, or perfect intervals
or
Augmented or diminished intervals

the reason raised this issue
as you can see
Ab (A Flat) naming :

  • in diatonic is written as m6 stand for minor sixth
  • in whole tone scale is written as A5 stand for augmented fifth

screen_shot 1
screen_shot

thanks

@mikehadlow
Copy link
Owner

OK, I see what you mean. So for a whole tone scale in C you'd expect to see:
C-1 D-M2 E-M3 Gb-A4 Ab-m6 Bb-m7 ?

@sugizo
Copy link
Author

sugizo commented Sep 8, 2020

yeah, btw, your current work is not wrong, just nice to have a button to select between the interval name
Minor, major, or perfect intervals
or
Augmented or diminished intervals

some learn interval name using minor, major or perfect interval name, but some usually use augmented or diminished intervals name

perhaps this button value can be store in cookies too (human behaviour is not always same each other)

thanks

@mikehadlow mikehadlow added the bug label Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants