Always run nsurlconnection requests on the main thread

Author: pjrobertson

Info.plist

@@ -19,9 +19,9 @@
 	<key>CFBundlePackageType</key>
 	<string>BNDL</string>
 	<key>CFBundleShortVersionString</key>
-	<string>1.0.2</string>
+	<string>1.0.3</string>
 	<key>CFBundleVersion</key>
-	<string>A4</string>
+	<string>A5</string>
 	<key>NSPrincipalClass</key>
 	<string>QSTwitterUtil</string>
 	<key>QSActions</key>
@@ -148,17 +148,17 @@
 &lt;p&gt;Enables posting of tweets, messages and direct messages to Twitter from within Quicksilver&lt;/p&gt;
 &lt;h4&gt;Setup&lt;/h4&gt;
 &lt;p&gt;&lt;strong&gt;Twitter Login&lt;/strong&gt;&lt;/p&gt;
-&lt;p&gt;In order to post tweets from Quicksilver, you must authenticate Quicksilver with your Twitter account. Do this by going to the &lt;a href="qs://preferences#QSTwitterPrefPane"&gt;Twitter plugin preferences&lt;/a&gt; and clicking the 'Sign In' button.
-Your Twitter login details are stored securely in OS X's Keychain.app for access across computer and app relaunches. You can remove the login details at any time by clicking the 'Sign Out' button in the Twitter preference pane.&lt;/p&gt;
+&lt;p&gt;In order to post tweets from Quicksilver, you must authenticate Quicksilver with your Twitter account. Do this by going to the &lt;a href=&quot;qs://preferences#QSTwitterPrefPane&quot;&gt;Twitter plugin preferences&lt;/a&gt; and clicking the &apos;Sign In&apos; button.
+Your Twitter login details are stored securely in OS X&apos;s Keychain.app for access across computer and app relaunches. You can remove the login details at any time by clicking the &apos;Sign Out&apos; button in the Twitter preference pane.&lt;/p&gt;
 &lt;p&gt;&lt;strong&gt;Twitter Contacts&lt;/strong&gt;&lt;/p&gt;
-&lt;p&gt;Some actions require a contact to send a direct message/message to. These actions accept both text (e.g. in the form '@Twitter') or a contact from your Address Book (requires the Contacts plugin). In order to use contacts directly, you must ensure that your contacts have their Twitter username field set in Address Book.app / Contacts.app&lt;/p&gt;
+&lt;p&gt;Some actions require a contact to send a direct message/message to. These actions accept both text (e.g. in the form &apos;@Twitter&apos;) or a contact from your Address Book (requires the Contacts plugin). In order to use contacts directly, you must ensure that your contacts have their Twitter username field set in Address Book.app / Contacts.app&lt;/p&gt;
 &lt;h4&gt;Actions&lt;/h4&gt;
 &lt;p&gt;&lt;strong&gt;Send Tweet&lt;/strong&gt;&lt;/p&gt;
-&lt;p&gt;The 'Send Tweet' action takes text in Quicksilver's 1st pane and posts a tweet directly to Twitter&lt;/p&gt;
+&lt;p&gt;The &apos;Tweet&apos; action takes text in Quicksilver&apos;s 1st pane and posts a tweet directly to Twitter&lt;/p&gt;
 &lt;p&gt;&lt;strong&gt;Send Tweet… / Send Tweet To…&lt;/strong&gt;&lt;/p&gt;
-&lt;p&gt;Use the 'Send Tweet…' action to send a contact selected in Quicksilver's 1st pane (either a contact from your Contacts list or a username entered as text) the text entered in Quicksilver's 3rd pane. The 'Send Tweet To…' action works in reverse, taking text in Quicksilver's 1st pane and a contact in Quicksilver's 3rd pane.&lt;/p&gt;
+&lt;p&gt;Use the &apos;Tweet…&apos; action to send a contact selected in Quicksilver&apos;s 1st pane (either a contact from your Contacts list or a username entered as text) the text entered in Quicksilver&apos;s 3rd pane. The &apos;Send Tweet To…&apos; action works in reverse, taking text in Quicksilver&apos;s 1st pane and a contact in Quicksilver&apos;s 3rd pane.&lt;/p&gt;
 &lt;p&gt;&lt;strong&gt;Send Direct Message… / Send Direct Message To…&lt;/strong&gt;&lt;/p&gt;
-&lt;p&gt;'Send Direct Message…' can be used to send a contact (selected in Quicksilver's 1st pane) a direct message entered as text in Quicksilver's 3rd pane. The 'Send Direct Message To…' action works in reverse.&lt;/p&gt;</string>
+&lt;p&gt;&apos;Send Direct Message…&apos; can be used to send a contact (selected in Quicksilver&apos;s 1st pane) a direct message entered as text in Quicksilver&apos;s 3rd pane. The &apos;Send Direct Message To…&apos; action works in reverse.&lt;/p&gt;</string>
 		<key>icon</key>
 		<string>QSTwit</string>
 		<key>relatedBundles</key>

QSTwitter.xcodeproj/project.pbxproj

@@ -29,6 +29,7 @@
 		CDB3CD1516FD61CE00DF06BF /* GTMMIMEDocument.m in Sources */ = {isa = PBXBuildFile; fileRef = CDB3CD0C16FD61CD00DF06BF /* GTMMIMEDocument.m */; };
 		CDB3CD1616FD61CE00DF06BF /* GTMReadMonitorInputStream.m in Sources */ = {isa = PBXBuildFile; fileRef = CDB3CD0E16FD61CE00DF06BF /* GTMReadMonitorInputStream.m */; };
 		CDB3CD1816FDD79800DF06BF /* YAJL.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = CDB3CD1716FDD79800DF06BF /* YAJL.framework */; };
+		CDB485A8176B514B0093B282 /* QSFoundation.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 7F35FF3E07F9ACD90056051D /* QSFoundation.framework */; };
 		CDB497CE1718E49C0055F0C4 /* YAJL.framework in Copy Files */ = {isa = PBXBuildFile; fileRef = CDB3CD1716FDD79800DF06BF /* YAJL.framework */; };
 		CDE38B231702ED2D007A6BC1 /* AddressBook.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = CDE38B221702ED2D007A6BC1 /* AddressBook.framework */; };
 		CDE38B241702ED45007A6BC1 /* QSCore.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 7F35FF3C07F9ACD90056051D /* QSCore.framework */; };
@@ -113,6 +114,7 @@
 				35857B6810E213AB0054319B /* SystemConfiguration.framework in Frameworks */,
 				CDB3CCFB16FD5EB600DF06BF /* Security.framework in Frameworks */,
 				CDB3CCE416FD58A600DF06BF /* QSInterface.framework in Frameworks */,
+				CDB485A8176B514B0093B282 /* QSFoundation.framework in Frameworks */,
 				CDE38B241702ED45007A6BC1 /* QSCore.framework in Frameworks */,
 				CDB3CD1816FDD79800DF06BF /* YAJL.framework in Frameworks */,
 			);

QSTwitterUtil.m

@@ -83,18 +83,20 @@ -(QSObject *)tweet:(NSString *)message toUser:(NSString*)user {
     message = (NSString*) CFURLCreateStringByAddingPercentEscapes(NULL, (CFStringRef)message, NULL,CFSTR(":/?#[]@!$&’'()*+,;=."), kCFStringEncodingUTF8);
     [request setHTTPBody:[[NSString stringWithFormat:@"%@%@=%@", user ? [NSString stringWithFormat:@"screen_name=%@&", user] : @"" , user ? @"text" : @"status", message] dataUsingEncoding:NSUTF8StringEncoding]];
     [authentication authorizeRequest:request];
-    [NSURLConnection sendAsynchronousRequest:request queue:[NSOperationQueue currentQueue] completionHandler:^(NSURLResponse *resp, NSData *data, NSError *err) {
-        if (err != nil) {
-            [self twitterNotify:[NSString stringWithFormat:NSLocalizedStringFromTableInBundle(@"[Error] %@", nil, [NSBundle bundleForClass:[self class]], @"error sending tweet message"), [err localizedDescription]]];
-        } else {
-            NSDictionary *response = [data yajl_JSON];
-            if ([response valueForKey:@"text"]) {
-                [self twitterNotify:NSLocalizedStringFromTableInBundle(@"Tweet sent successfully", nil, [NSBundle bundleForClass:[self class]], nil)];
+    runOnMainQueueSync(^{
+        [NSURLConnection sendAsynchronousRequest:request queue:[NSOperationQueue currentQueue] completionHandler:^(NSURLResponse *resp, NSData *data, NSError *err) {
+            if (err != nil) {
+                [self twitterNotify:[NSString stringWithFormat:NSLocalizedStringFromTableInBundle(@"[Error] %@", nil, [NSBundle bundleForClass:[self class]], @"error sending tweet message"), [err localizedDescription]]];
             } else {
-                [self twitterNotify:[NSString stringWithFormat:@"[ERROR] %@",[response valueForKey:@"error"]]];
+                NSDictionary *response = [data yajl_JSON];
+                if ([response valueForKey:@"text"]) {
+                    [self twitterNotify:NSLocalizedStringFromTableInBundle(@"Tweet sent successfully", nil, [NSBundle bundleForClass:[self class]], nil)];
+                } else {
+                    [self twitterNotify:[NSString stringWithFormat:@"[ERROR] %@",[response valueForKey:@"error"]]];
+                }
             }
-        }
-    }];
+        }];
+    });
     return nil;
 
 }
@@ -153,13 +155,15 @@ - (void)windowController:(GTMOAuthWindowController *)windowController
 -(void)getCredentials {
     NSMutableURLRequest *request = [NSMutableURLRequest requestWithURL:kTwitterUserCredURL];
     [authentication authorizeRequest:request];
-    [NSURLConnection sendAsynchronousRequest:request queue:[NSOperationQueue currentQueue] completionHandler:^(NSURLResponse *response, NSData *data, NSError *err) {
-        if (data) {
-            [self.prefPane updateCredentials:[data yajl_JSON]];
-        } else {
-            [self.prefPane updateCredentials:@{@"name": [NSString stringWithFormat:@"[ERROR]: %@",[err localizedDescription]]}];
-        }
-    }];
+    runOnMainQueueSync(^{
+        [NSURLConnection sendAsynchronousRequest:request queue:[NSOperationQueue currentQueue] completionHandler:^(NSURLResponse *response, NSData *data, NSError *err) {
+            if (data) {
+                [self.prefPane updateCredentials:[data yajl_JSON]];
+            } else {
+                [self.prefPane updateCredentials:@{@"name": [NSString stringWithFormat:@"[ERROR]: %@",[err localizedDescription]]}];
+            }
+        }];
+    });
 }
 
 - (BOOL)isSignedIn {