Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change key icon in a11y view #229827

Closed
Tyriar opened this issue Sep 26, 2024 · 4 comments · Fixed by #236649
Closed

Change key icon in a11y view #229827

Tyriar opened this issue Sep 26, 2024 · 4 comments · Fixed by #236649
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Sep 26, 2024

I had to re-read these to figure out the difference, so maybe we should consider using different icons for each action. But I think we should be using keyboard here instead of a key. Keys say to me password, authentication, etc. Not a key/hoykeys on a keyboard.

Image
Image

@Tyriar
Copy link
Member Author

Tyriar commented Sep 26, 2024

Example icons I think would be better:

Image

New icon idea for unassigned:

Image

@meganrogge meganrogge added bug Issue identified by VS Code Team member as probable bug accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues labels Sep 26, 2024
@meganrogge meganrogge added this to the October 2024 milestone Sep 26, 2024
@meganrogge
Copy link
Contributor

Blocked by microsoft/vscode-codicons#263

@meganrogge meganrogge removed this from the October 2024 milestone Oct 1, 2024
@hbons
Copy link
Member

hbons commented Oct 3, 2024

@Tyriar are those existing icons? I don't think we have tin the set but I can create. Thinking about fewer keys though.

edit: found it:

image

@meganrogge
Copy link
Contributor

ideally, we'd have distinct keyboard icons. It might be awhile before we can have those, so considering this fixed with the switch from 🔑 to ⌨

@vs-code-engineering vs-code-engineering bot added the unreleased Patch has not yet been released in VS Code Insiders label Dec 19, 2024
@vs-code-engineering vs-code-engineering bot added this to the January 2025 milestone Dec 19, 2024
@vs-code-engineering vs-code-engineering bot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Dec 20, 2024
@rzhao271 rzhao271 added the verified Verification succeeded label Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants