Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem parsing file icon theme with non-english display language #203823

Closed
miguelsolorio opened this issue Jan 30, 2024 · 2 comments
Closed

Problem parsing file icon theme with non-english display language #203823

miguelsolorio opened this issue Jan 30, 2024 · 2 comments
Assignees
Labels
info-needed Issue requires more information from poster themes Color theme issues

Comments

@miguelsolorio
Copy link
Contributor

miguelsolorio commented Jan 30, 2024

I created this Symbols File Icon Theme that I've noticed users reporting issues installing/activating the extensions but it seems to only happen in systems with different languages (i.e. non-english). I've never seen this error before and wondering if you may know what is happening so I can help fix or if it's a VS Code issue.

Users have reported that installing an older version and re-installing the current version fixes the issues 🤷

Here are examples of the errors:

image

Problems parsing file icons file: Invalid symbol, Value expected

CleanShot 2024-01-30 at 09 56 50@2x

A problem occurred while parsing the file icon file: invalid symbol, invalid symbol,, invalid symbol, the file should...

cc @aeschli 👋

@miguelsolorio miguelsolorio changed the title Problems File icon errors with different local languages Problem parsing file icon theme Jan 30, 2024
@aeschli
Copy link
Contributor

aeschli commented Jan 31, 2024

I'm not aware of that error.
I tried to reproduce but didn't hit the issue.

The error comes from here:

return Promise.reject(new Error(nls.localize('error.cannotparseicontheme', "Problems parsing product icons file: {0}", parseErrors.map(e => getParseErrorMessage(e.error)).join(', '))));

If you see this and have a chance to debug this. The loaded content of the file icon theme seems to be corrupt.

@aeschli aeschli added the themes Color theme issues label Jan 31, 2024
@aeschli aeschli changed the title Problem parsing file icon theme Problem parsing file icon theme with non-english display language Jan 31, 2024
@aeschli aeschli added the info-needed Issue requires more information from poster label Jan 31, 2024
@vscodenpa
Copy link

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

@vscodenpa vscodenpa closed this as not planned Won't fix, can't repro, duplicate, stale Feb 7, 2024
@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster themes Color theme issues
Projects
None yet
Development

No branches or pull requests

3 participants