Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSX Linked Editing not working with Vim extension #184829

Open
peterjuras opened this issue Jun 11, 2023 · 5 comments
Open

JSX Linked Editing not working with Vim extension #184829

peterjuras opened this issue Jun 11, 2023 · 5 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug editor-synced-region Issues related to synced region functionality in editor
Milestone

Comments

@peterjuras
Copy link

peterjuras commented Jun 11, 2023

Does this issue occur when all extensions are disabled?: Yes/No

  • VS Code Version: 1.79.0
  • OS Version: Windows 11 Pro 22621.1778

Steps to Reproduce:

  1. Open a file that contains JSX elements
  2. Navigate to an opening tag of JSX, e.g. the <div> in the example below
  3. Place the Vim cursor over the "d" and press c + w (change word)
  4. The closing tag is automatically deleted ✅
  5. Update the tag to "section" and press Escape
    -> The closing tag is not updated ❌

Note: The linked editing feature does appear to work on a single line <div>, but in the case below it fails.

Example source code:

return (
    <div className={containerClasses}>
      <Spinner />
    </div>
  );

Example video showing the issue:

Recording.2023-06-11.093009.mp4
@fsgreco
Copy link

fsgreco commented Jun 14, 2023

I have the same bug

VSCode version: 1.79.1
Os Version: x86_64 Linux 6.3.7-arch1-1

@ya2s
Copy link

ya2s commented Jul 19, 2023

The same problem occurs even when using vscode-neovim. I want it fixed as soon as possible

@aeschli aeschli added editor-synced-region Issues related to synced region functionality in editor bug Issue identified by VS Code Team member as probable bug labels Aug 21, 2023
@aeschli aeschli added this to the Backlog milestone Aug 21, 2023
@ya2s
Copy link

ya2s commented Sep 10, 2023

@aeschli
It also works well with vscode-neovim if we use the extension
https://marketplace.visualstudio.com/items?itemName=formulahendry.auto-rename-tag

However, I still want to use it as a built-in function.

@musjj
Copy link

musjj commented May 3, 2024

This isn't a Vim plugin bug, you can reproduce it without it. Turn off the extension, then backspace the entire tag and start typing. You'll see the same issue.

Maybe a separate issue should be made?

@LucasOe
Copy link

LucasOe commented Aug 8, 2024

@musjj There's already #185279

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug editor-synced-region Issues related to synced region functionality in editor
Projects
None yet
Development

No branches or pull requests

8 participants