Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update attach.ts to fix "clientOS" configuration #24790

Closed
wants to merge 1 commit into from

Conversation

cute-cirno
Copy link

Fix "clientOS" options

My debugger works in VS Code versions <=1.71.2. In higher versions, it can attach but fails to hit breakpoints. By comparing the logs, I found that in higher versions of VS Code, the option "WindowsClient" was missing during the debugger initialization. I manually added it, and the breakpoints were successfully hit.

So, I reviewed the code of this plugin and found that the options "WindowsClient" and "UnixClient" were defined but not set according to "clientOS".

@karthiknadig
Copy link
Member

I think this is a bug in debugpy. see here microsoft/vscode-python-debugger#587 (comment)

This was intentionally removed as debugpy added support to read this config setting.

removal PR: https://github.com/microsoft/vscode-python/pull/20805/files
Debugpy code where clientOS is read: https://github.com/microsoft/debugpy/blob/fb0b06cab161478db95420c5bfb485c39d508f62/src/debugpy/_vendored/pydevd/_pydevd_bundle/pydevd_json_debug_options.py#L98-L99

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants