-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On PR to submodule parent package was forked instead of submodule #6492
Labels
bug
Issue identified by VS Code Team member as probable bug
verification-found
Issue verification failed
Milestone
Comments
Tried with https://github.com/chrmarti/test-main-repo and https://github.com/chrmarti/test-sub-repo. It forked the submodule as https://github.com/notquiteme/test-sub-repo and updated the git remotes to PR output channel:
Git output channel:
|
chrmarti
added
verification-found
Issue verification failed
and removed
verified
Verification succeeded
labels
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Issue identified by VS Code Team member as probable bug
verification-found
Issue verification failed
Steps to Reproduce:
tl;dr: On PR create for submodule, extension will fork main repository instead of submodule.
Looks like it's the same as
#4487
#5181
We found issue on diplodoc metapackage. But it is reproducible on any repo with submodules.
Prerequisites:
Metapackage - organisation owned repo with submodules and enabled codespaces.
Submodule - any organisation owned repo linked to metapackage.
Alice - user out of organization scope.
9.1 Current behaviour: fork for metapackage was created, pr flow was broken on next step with reasonable error.
9.2 Expected behaviour: fork for submodule was created, pr flow finished succesefully.
The text was updated successfully, but these errors were encountered: