Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not able to pull up Overview page from the "pull request" view: #4768

Closed
karthiknadig opened this issue Apr 25, 2023 · 2 comments · Fixed by #4786
Closed

Not able to pull up Overview page from the "pull request" view: #4768

karthiknadig opened this issue Apr 25, 2023 · 2 comments · Fixed by #4786
Assignees
@alexr00
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
May 2023

Comments

@karthiknadig
Copy link
Member

Testing #4764

I am not able to pull up Overview page from the "pull request" view:
image

Clicking on the pull request title does nothing.

I see this error:
image

notificationsAlerts.ts:40 TypeError: Cannot read properties of undefined (reading 'title')
    at og.getTreeItem (c:\Users\kanadig\.vscode-insiders\extensions\github.vscode-pull-request-github-0.63.2023042509\dist\extension.js:1710:48743)
    at c:\Users\kanadig\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:98:65297
    at Array.map (<anonymous>)
    at y.R (c:\Users\kanadig\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:98:65262)
    at y.getChildren (c:\Users\kanadig\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:98:61563)
c @ notificationsAlerts.ts:40
@alexr00
Copy link
Member

alexr00 commented Apr 26, 2023

@karthiknadig I've fixed the error and the fix will be available in the next pre-release build, though I wouldn't expect that to cause the PR description to not show. Can you install the latest pre-release, repro the issue, then share the output of GitHub Pull Request?

@alexr00 alexr00 added info-needed Issue requires more information from poster bug Issue identified by VS Code Team member as probable bug labels Apr 26, 2023
@alexr00 alexr00 added this to the May 2023 milestone Apr 28, 2023
@alexr00
Copy link
Member

alexr00 commented Apr 28, 2023

Just ran into this issue myself. It's an issue with using SSH remotes.

@alexr00 alexr00 mentioned this issue Apr 28, 2023
Merged
alexr00 added a commit that referenced this issue Apr 28, 2023
@alexr00
Fix open PR description for SSH remotes
9e51028 
Fixes #4768
@alexr00 alexr00 removed the info-needed Issue requires more information from poster label Apr 28, 2023
@alexr00 alexr00 mentioned this issue May 2, 2023
Closed
alexr00 added a commit that referenced this issue May 9, 2023
@alexr00
Fix open PR description for SSH remotes (#4786)
c9bf9cb 
* Fix open PR description for SSH remotes
Fixes #4768

* Remove path
@joyceerhl joyceerhl added the verified Verification succeeded label May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexr00 alexr00

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
May 2023
Development

Successfully merging a pull request may close this issue.

Fix open PR description for SSH remotes microsoft/vscode-pull-request-github
3 participants
@karthiknadig @joyceerhl @alexr00