Fixes #184, Overview button state should be reset when checkout fails

Rachel Macfarlane · Rachel Macfarlane · commit c3ccb292c867 · 2018-08-13T16:53:13.000-07:00
diff --git a/src/view/reviewManager.ts b/src/view/reviewManager.ts
@@ -757,7 +757,7 @@ export class ReviewManager implements vscode.DecorationProvider {
 		let isDirty = await this._repository.isDirty();
 		if (isDirty) {
 			vscode.window.showErrorMessage('Your local changes would be overwritten by checkout, please commit your changes or stash them before you switch branches');
-			return;
+			throw new Error('Has local changes');
 		}
 
 		this.statusBarItem.text = '$(sync~spin) Switching to Review Mode';

Original file line number	Diff line number	Diff line change
`@@ -757,7 +757,7 @@ export class ReviewManager implements vscode.DecorationProvider {`
`757`	`757`	`let isDirty = await this._repository.isDirty();`
`758`	`758`	`if (isDirty) {`
`759`	`759`	`vscode.window.showErrorMessage('Your local changes would be overwritten by checkout, please commit your changes or stash them before you switch branches');`
`760`		`- return;`
	`760`	`+ throw new Error('Has local changes');`
`761`	`761`	`}`
`762`	`762`
`763`	`763`	`this.statusBarItem.text = '$(sync~spin) Switching to Review Mode';`