Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of deprecated mongo methods #1306

Open
ejizba opened this issue Jan 22, 2020 · 3 comments
Open

Remove usage of deprecated mongo methods #1306

ejizba opened this issue Jan 22, 2020 · 3 comments
Labels
bug The issue reveals something not working as expected. engineering The issue describes potential improvements that can boost dev productivity. mongo P1 scrapbook

Comments

@ejizba
Copy link
Contributor

ejizba commented Jan 22, 2020

Related to #1281 (comment) and #1298, seems like we're using deprecated mongo methods in a few places. We should go through and fix all of those

A few examples: count, remove, insert

@ejizba ejizba added the bug The issue reveals something not working as expected. label Mar 10, 2020
@ejizba
Copy link
Contributor Author

ejizba commented Mar 10, 2020

Also we're seeing this in the Mongo output window on activation:

the options [appName] is not supported
[Error - 11:15:02 AM] (node:81124) DeprecationWarning: current Server Discovery and Monitoring engine is deprecated, and will be removed in a future version. To use the new Server Discover and Monitoring engine, pass option { useUnifiedTopology: true } to the MongoClient constructor.

@ejizba ejizba added this to the 0.13.0 milestone Mar 10, 2020
@ejizba ejizba added the P1 label Mar 10, 2020
@nturinski
Copy link
Member

I think the options appName portion is related to a change I made for private endpoints.

#1262

@ejizba
Copy link
Contributor Author

ejizba commented May 22, 2020

I looked into preventing the output channel from popping up, but it's a little complicated because it's not our default output channel, it's an output channel handled by the "vscode-languageclient" module. There's an option "revealOutputChannelOn", but if I set it to "Never" that hides all errors and I'm not sure I'm ready to commit to that on short notice. Will move to the next milestone

Also - doesn't affect all users of the extension, just ones that have connected a Mongo db.

@ejizba ejizba modified the milestones: 0.13.0, 0.14.0 May 22, 2020
@wwlorey wwlorey modified the milestones: 0.14.0, 0.15.0 Jul 13, 2020
@neelip neelip modified the milestones: 0.16.0, 0.17.0 Nov 11, 2020
@ejizba ejizba modified the milestones: 0.17.0, Backlog Candidates Apr 5, 2021
@ejizba ejizba added the engineering The issue describes potential improvements that can boost dev productivity. label Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue reveals something not working as expected. engineering The issue describes potential improvements that can boost dev productivity. mongo P1 scrapbook
Projects
None yet
Development

No branches or pull requests

4 participants