Skip to content

Commit 986a875

Browse files
Mongo- Doc&Coll - Remove ObjectID constructor from update operation (#671)
* Mongo- Doc&Coll - Remove ObjectID constructor from update operation * Remove unused import. Fixes tsc -p failure.
1 parent 2fb1060 commit 986a875

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/mongo/tree/MongoCollectionTreeItem.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import * as vscode from 'vscode';
77
import * as path from 'path';
88
import * as _ from 'underscore';
99
import * as vscodeUtils from '../../utils/vscodeUtils';
10-
import { Collection, Cursor, ObjectID, InsertOneWriteOpResult, BulkWriteOpResultObject, CollectionInsertManyOptions } from 'mongodb';
10+
import { Collection, Cursor, InsertOneWriteOpResult, BulkWriteOpResultObject, CollectionInsertManyOptions } from 'mongodb';
1111
import { IAzureParentTreeItem, IAzureTreeItem, IAzureNode, UserCancelledError, DialogResponses } from 'vscode-azureextensionui';
1212
import { DefaultBatchSize } from '../../constants';
1313
import { IMongoDocument, MongoDocumentTreeItem } from './MongoDocumentTreeItem';
@@ -36,7 +36,7 @@ export class MongoCollectionTreeItem implements IAzureParentTreeItem {
3636
const operations = documents.map((document) => {
3737
return {
3838
updateOne: {
39-
filter: { _id: new ObjectID(document._id) },
39+
filter: { _id: document._id },
4040
update: _.omit(document, '_id'),
4141
upsert: false
4242
}

src/mongo/tree/MongoDocumentTreeItem.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ export class MongoDocumentTreeItem implements IAzureTreeItem {
6767
if (!newDocument["_id"]) {
6868
throw new Error(`The "_id" field is required to update a document.`);
6969
}
70-
const filter: object = { _id: new ObjectID(newDocument._id) };
70+
const filter: object = { _id: newDocument._id };
7171
const result: UpdateWriteOpResult = await collection.updateOne(filter, _.omit(newDocument, '_id'));
7272
if (result.modifiedCount != 1) {
7373
throw new Error(`Failed to update document with _id '${newDocument._id}'.`);

0 commit comments

Comments
 (0)