From 14ea12a73b845b074420138fd740254b8a9af970 Mon Sep 17 00:00:00 2001
From: Sevo Kukol <sevoku@microsoft.com>
Date: Thu, 18 Jul 2024 13:34:55 +0200
Subject: [PATCH] Show RBAC notification only once per account item.

Sometimes the resource tree continously refreshes all expanded nodes
and if authentication fails the RBAC notification pops up again and again.

With this change we show the notification only once for each account node.
Refreshing the parent (resource group) node will create a new instance
and show the notification again.
---
 src/docdb/tree/DocDBAccountTreeItemBase.ts | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/docdb/tree/DocDBAccountTreeItemBase.ts b/src/docdb/tree/DocDBAccountTreeItemBase.ts
index e13fa3194..dbba7239b 100644
--- a/src/docdb/tree/DocDBAccountTreeItemBase.ts
+++ b/src/docdb/tree/DocDBAccountTreeItemBase.ts
@@ -24,7 +24,7 @@ import { DocDBTreeItemBase } from './DocDBTreeItemBase';
 export abstract class DocDBAccountTreeItemBase extends DocDBTreeItemBase<DatabaseDefinition & Resource> {
     public readonly label: string;
     public readonly childTypeLabel: string = "Database";
-
+    private showRbacNotification: boolean = true;
 
     constructor(
         parent: AzExtParentTreeItem,
@@ -93,7 +93,8 @@ export abstract class DocDBAccountTreeItemBase extends DocDBTreeItemBase<Databas
             try {
                 return await super.loadMoreChildrenImpl(clearCache, context);
             } catch (e) {
-                if (e instanceof Error && isRbacException(e)) {
+                if (e instanceof Error && isRbacException(e) && this.showRbacNotification) {
+                    this.showRbacNotification = false;
                     const principalId = await getSignedInPrincipalIdForAccountEndpoint(this.root.endpoint) ?? '';
                     // chedck if the principal ID matches the one that is signed in, otherwise this might be a security problem, hence show the error message
                     if (e.message.includes(`[${principalId}]`) && await ensureRbacPermission(this, principalId, context)) {