-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to mappings and automate manual steps #196
Comments
Priorities:
|
|
I've completed the following:
On the vscode side I've split up the list of icons into a library and a derived list. The library is a separate file that the codicons build generates with a new script: The only missing step is to automatically create a PR to The rest of the ideas above are stretch goals. Having automated PRs to VS Code is the major time saver. @mrleemurray would love your help with this last step. :) |
Separate issue for the mapping improvements: #239 |
Right now adding/changing icons in VS Code feels like it needs too many manual steps.
Issues:
icons.ttf
causes unresolvable conflicts and blocks having multiple PRs open in progress. It should probably not be kept in the git repo being a binary file.mapping.json
icons.ttf
needs to be manually committed to the main vscode repoPossible improvements:
dist/icons.*
to the Releases page. This way we keep the repo free of conflicts and can have multiple ongoing PRs open at the same timemapping.json
. This way we can see which icon names map to the same icon, and we don't need to add numbers. This will also make the mappings much easier to edit.icons.ttf
MAGIC LEVEL:
We can ask Lee to help us with this.
cc @daviddossett
The text was updated successfully, but these errors were encountered: