Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Span trim stack trace #4368

Closed
wants to merge 7 commits into from
Closed

Span trim stack trace #4368

wants to merge 7 commits into from

Conversation

SimonCropp
Copy link
Contributor

No description provided.

@SimonCropp SimonCropp marked this pull request as draft December 17, 2024 00:48
@Youssef1313
Copy link
Member

@SimonCropp Thanks for improving this!

I'm curious, did you have a scenario where you have seen this in a performance trace? Or did you work on this because of #4266 ?

@SimonCropp
Copy link
Contributor Author

@Youssef1313 just 4266

@SimonCropp
Copy link
Contributor Author

@Youssef1313
thoughts on adding System.ValueTuple and System.Memory TestFramework.csproj for some older tfms? i need that to make the polyfill work. if u dont like it can can go a different direction

@SimonCropp
Copy link
Contributor Author

@Youssef1313
thoughts on adding System.ValueTuple and System.Memory TestFramework.csproj for some older tfms? i need that to make the polyfill work. if u dont like it can can go a different direction

i assume no resposne is a NO. so will close

@SimonCropp SimonCropp closed this Feb 7, 2025
@SimonCropp SimonCropp deleted the span-TrimStackTrace branch February 7, 2025 01:31
@Youssef1313
Copy link
Member

Sorry @SimonCropp, this slipped off our radar and I and @Evangelink haven't discussed this specifically yet. But generally we try to be very careful when introducing dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoRossignoli MarcoRossignoli Awaiting requested review from MarcoRossignoli

@Evangelink Evangelink Awaiting requested review from Evangelink

@Youssef1313 Youssef1313 Awaiting requested review from Youssef1313 Youssef1313 will be requested when the pull request is marked ready for review Youssef1313 is a code owner

@nohwnd nohwnd Awaiting requested review from nohwnd nohwnd will be requested when the pull request is marked ready for review nohwnd is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SimonCropp @Youssef1313