You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This issue serves as a proposal for changes related to attributes and how we do the reflection.
ALL calls to GetCustomAttributes should use inherit: true.
Attributes that are not inheritable (e.g, TestClassAttribute), will have Inherited = false in their attribute usage.
This means two things:
Even if we use inherit: true, they are not inherited because of the attribute usage.
Users are allowed to introduce a new attribute, class MyTestClassAttribute : TestClassAttribute that has AttributeUsage with Inherited = true, in that case, we allow inheritance, as it's explicitly stated by the user.
More changes may be needed to have better and consistent experience, but this may be a good first step aimed for v4
This issue serves as a proposal for changes related to attributes and how we do the reflection.
ALL calls to
GetCustomAttributes
should useinherit: true
.Attributes that are not inheritable (e.g, TestClassAttribute), will have
Inherited = false
in their attribute usage.This means two things:
inherit: true
, they are not inherited because of the attribute usage.class MyTestClassAttribute : TestClassAttribute
that has AttributeUsage withInherited = true
, in that case, we allow inheritance, as it's explicitly stated by the user.More changes may be needed to have better and consistent experience, but this may be a good first step aimed for v4
cc @Evangelink
The text was updated successfully, but these errors were encountered: