Skip to content

[Graph] Use comma array format for parameters #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 19, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
29 changes: 1 addition & 28 deletions packages/graph/scripts/client.ts.template
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{{#if (notEmpty endpoints)}}
import qs from 'qs';
import { getInjectedUrl } from '@utils/url';
{{/if}}
import * as http from '@microsoft/spark.common/http';

@@ -11,33 +11,6 @@ import type { Endpoints } from './{{types}}-types.ts';
import { {{capitalize @key}}Client } from './{{@key}}';
{{/each}}

{{#if (notEmpty endpoints)}}
interface Param {
readonly in: string;
readonly name: string;
}
{{/if}}

{{#if (notEmpty endpoints)}}
function getInjectedUrl(url: string, params: Array<Param>, data: Record<string, any>) {
const query: Record<string, any> = { };

for (const param of params) {
if (param.in === 'query') {
query[param.name] = data[param.name];
}

if (param.in !== 'path') {
continue;
}

url = url.replace(`{${param.name}}`, data[param.name]);
}

return `${url}${qs.stringify(query, { addQueryPrefix: true })}`;
}
{{/if}}

/**
* {{url}}
{{#if description}}
25 changes: 1 addition & 24 deletions packages/graph/src/appCatalogs/index.ts
Original file line number Diff line number Diff line change
@@ -1,33 +1,10 @@
import qs from 'qs';
import { getInjectedUrl } from '@utils/url';
import * as http from '@microsoft/spark.common/http';

import pkg from 'src/../package.json';
import type { Endpoints } from './index-types.ts';
import { TeamsAppsClient } from './teamsApps';

interface Param {
readonly in: string;
readonly name: string;
}

function getInjectedUrl(url: string, params: Array<Param>, data: Record<string, any>) {
const query: Record<string, any> = {};

for (const param of params) {
if (param.in === 'query') {
query[param.name] = data[param.name];
}

if (param.in !== 'path') {
continue;
}

url = url.replace(`{${param.name}}`, data[param.name]);
}

return `${url}${qs.stringify(query, { addQueryPrefix: true })}`;
}

/**
* /appCatalogs
* Provides operations to manage the appCatalogs singleton.
25 changes: 1 addition & 24 deletions packages/graph/src/appCatalogs/teamsApps/appDefinitions/bot.ts
Original file line number Diff line number Diff line change
@@ -1,32 +1,9 @@
import qs from 'qs';
import { getInjectedUrl } from '@utils/url';
import * as http from '@microsoft/spark.common/http';

import pkg from 'src/../package.json';
import type { Endpoints } from './bot-types.ts';

interface Param {
readonly in: string;
readonly name: string;
}

function getInjectedUrl(url: string, params: Array<Param>, data: Record<string, any>) {
const query: Record<string, any> = {};

for (const param of params) {
if (param.in === 'query') {
query[param.name] = data[param.name];
}

if (param.in !== 'path') {
continue;
}

url = url.replace(`{${param.name}}`, data[param.name]);
}

return `${url}${qs.stringify(query, { addQueryPrefix: true })}`;
}

/**
* /appCatalogs/teamsApps/{teamsApp-id}/appDefinitions/{teamsAppDefinition-id}/bot
* Provides operations to manage the bot property of the microsoft.graph.teamsAppDefinition entity.
25 changes: 1 addition & 24 deletions packages/graph/src/appCatalogs/teamsApps/appDefinitions/index.ts
Original file line number Diff line number Diff line change
@@ -1,33 +1,10 @@
import qs from 'qs';
import { getInjectedUrl } from '@utils/url';
import * as http from '@microsoft/spark.common/http';

import pkg from 'src/../package.json';
import type { Endpoints } from './index-types.ts';
import { BotClient } from './bot';

interface Param {
readonly in: string;
readonly name: string;
}

function getInjectedUrl(url: string, params: Array<Param>, data: Record<string, any>) {
const query: Record<string, any> = {};

for (const param of params) {
if (param.in === 'query') {
query[param.name] = data[param.name];
}

if (param.in !== 'path') {
continue;
}

url = url.replace(`{${param.name}}`, data[param.name]);
}

return `${url}${qs.stringify(query, { addQueryPrefix: true })}`;
}

/**
* /appCatalogs/teamsApps/{teamsApp-id}/appDefinitions
* Provides operations to manage the appDefinitions property of the microsoft.graph.teamsApp entity.
25 changes: 1 addition & 24 deletions packages/graph/src/appCatalogs/teamsApps/index.ts
Original file line number Diff line number Diff line change
@@ -1,33 +1,10 @@
import qs from 'qs';
import { getInjectedUrl } from '@utils/url';
import * as http from '@microsoft/spark.common/http';

import pkg from 'src/../package.json';
import type { Endpoints } from './index-types.ts';
import { AppDefinitionsClient } from './appDefinitions';

interface Param {
readonly in: string;
readonly name: string;
}

function getInjectedUrl(url: string, params: Array<Param>, data: Record<string, any>) {
const query: Record<string, any> = {};

for (const param of params) {
if (param.in === 'query') {
query[param.name] = data[param.name];
}

if (param.in !== 'path') {
continue;
}

url = url.replace(`{${param.name}}`, data[param.name]);
}

return `${url}${qs.stringify(query, { addQueryPrefix: true })}`;
}

/**
* /appCatalogs/teamsApps
* Provides operations to manage the teamsApps property of the microsoft.graph.appCatalogs entity.
25 changes: 1 addition & 24 deletions packages/graph/src/appRoleAssignments/checkMemberGroups.ts
Original file line number Diff line number Diff line change
@@ -1,32 +1,9 @@
import qs from 'qs';
import { getInjectedUrl } from '@utils/url';
import * as http from '@microsoft/spark.common/http';

import pkg from 'src/../package.json';
import type { Endpoints } from './checkMemberGroups-types.ts';

interface Param {
readonly in: string;
readonly name: string;
}

function getInjectedUrl(url: string, params: Array<Param>, data: Record<string, any>) {
const query: Record<string, any> = {};

for (const param of params) {
if (param.in === 'query') {
query[param.name] = data[param.name];
}

if (param.in !== 'path') {
continue;
}

url = url.replace(`{${param.name}}`, data[param.name]);
}

return `${url}${qs.stringify(query, { addQueryPrefix: true })}`;
}

/**
* /appRoleAssignments/{appRoleAssignment-id}/checkMemberGroups
* Provides operations to call the checkMemberGroups method.
25 changes: 1 addition & 24 deletions packages/graph/src/appRoleAssignments/checkMemberObjects.ts
Original file line number Diff line number Diff line change
@@ -1,32 +1,9 @@
import qs from 'qs';
import { getInjectedUrl } from '@utils/url';
import * as http from '@microsoft/spark.common/http';

import pkg from 'src/../package.json';
import type { Endpoints } from './checkMemberObjects-types.ts';

interface Param {
readonly in: string;
readonly name: string;
}

function getInjectedUrl(url: string, params: Array<Param>, data: Record<string, any>) {
const query: Record<string, any> = {};

for (const param of params) {
if (param.in === 'query') {
query[param.name] = data[param.name];
}

if (param.in !== 'path') {
continue;
}

url = url.replace(`{${param.name}}`, data[param.name]);
}

return `${url}${qs.stringify(query, { addQueryPrefix: true })}`;
}

/**
* /appRoleAssignments/{appRoleAssignment-id}/checkMemberObjects
* Provides operations to call the checkMemberObjects method.
Original file line number Diff line number Diff line change
@@ -1,32 +1,9 @@
import qs from 'qs';
import { getInjectedUrl } from '@utils/url';
import * as http from '@microsoft/spark.common/http';

import pkg from 'src/../package.json';
import type { Endpoints } from './getAvailableExtensionProperties-types.ts';

interface Param {
readonly in: string;
readonly name: string;
}

function getInjectedUrl(url: string, params: Array<Param>, data: Record<string, any>) {
const query: Record<string, any> = {};

for (const param of params) {
if (param.in === 'query') {
query[param.name] = data[param.name];
}

if (param.in !== 'path') {
continue;
}

url = url.replace(`{${param.name}}`, data[param.name]);
}

return `${url}${qs.stringify(query, { addQueryPrefix: true })}`;
}

/**
* /appRoleAssignments/getAvailableExtensionProperties
* Provides operations to call the getAvailableExtensionProperties method.
25 changes: 1 addition & 24 deletions packages/graph/src/appRoleAssignments/getByIds.ts
Original file line number Diff line number Diff line change
@@ -1,32 +1,9 @@
import qs from 'qs';
import { getInjectedUrl } from '@utils/url';
import * as http from '@microsoft/spark.common/http';

import pkg from 'src/../package.json';
import type { Endpoints } from './getByIds-types.ts';

interface Param {
readonly in: string;
readonly name: string;
}

function getInjectedUrl(url: string, params: Array<Param>, data: Record<string, any>) {
const query: Record<string, any> = {};

for (const param of params) {
if (param.in === 'query') {
query[param.name] = data[param.name];
}

if (param.in !== 'path') {
continue;
}

url = url.replace(`{${param.name}}`, data[param.name]);
}

return `${url}${qs.stringify(query, { addQueryPrefix: true })}`;
}

/**
* /appRoleAssignments/getByIds
* Provides operations to call the getByIds method.
25 changes: 1 addition & 24 deletions packages/graph/src/appRoleAssignments/getMemberGroups.ts
Original file line number Diff line number Diff line change
@@ -1,32 +1,9 @@
import qs from 'qs';
import { getInjectedUrl } from '@utils/url';
import * as http from '@microsoft/spark.common/http';

import pkg from 'src/../package.json';
import type { Endpoints } from './getMemberGroups-types.ts';

interface Param {
readonly in: string;
readonly name: string;
}

function getInjectedUrl(url: string, params: Array<Param>, data: Record<string, any>) {
const query: Record<string, any> = {};

for (const param of params) {
if (param.in === 'query') {
query[param.name] = data[param.name];
}

if (param.in !== 'path') {
continue;
}

url = url.replace(`{${param.name}}`, data[param.name]);
}

return `${url}${qs.stringify(query, { addQueryPrefix: true })}`;
}

/**
* /appRoleAssignments/{appRoleAssignment-id}/getMemberGroups
* Provides operations to call the getMemberGroups method.
25 changes: 1 addition & 24 deletions packages/graph/src/appRoleAssignments/getMemberObjects.ts
Original file line number Diff line number Diff line change
@@ -1,32 +1,9 @@
import qs from 'qs';
import { getInjectedUrl } from '@utils/url';
import * as http from '@microsoft/spark.common/http';

import pkg from 'src/../package.json';
import type { Endpoints } from './getMemberObjects-types.ts';

interface Param {
readonly in: string;
readonly name: string;
}

function getInjectedUrl(url: string, params: Array<Param>, data: Record<string, any>) {
const query: Record<string, any> = {};

for (const param of params) {
if (param.in === 'query') {
query[param.name] = data[param.name];
}

if (param.in !== 'path') {
continue;
}

url = url.replace(`{${param.name}}`, data[param.name]);
}

return `${url}${qs.stringify(query, { addQueryPrefix: true })}`;
}

/**
* /appRoleAssignments/{appRoleAssignment-id}/getMemberObjects
* Provides operations to call the getMemberObjects method.
Loading