.Net: Bug: .NET search option classes duplication

[dluc]

This is probably already in your radar but I don't see it in the backlog.

These two classes are very similar and could be consolidated to avoid code duplication.

• Microsoft.Extensions.VectorData.VectorSearchOptions<TRecord>
• Microsoft.Extensions.VectorData.HybridSearchOptions<TRecord>

Note: Top and Skip validation is different

[roji]

HybridSearchOptions has AdditionalProperty to select the full-text property - IIRC that's the reason for having two (/cc @westey-m). We could make HybridSearchOptions extend VectorSearchOptions if we want.

[westey-m]

Yep @roji, that's correct. HybridSearchOptions does have AdditionalProperty.
That said, since everything on both options classes are optional, including AdditionalProperty, we could introduce some simple lossy helpers to convert between these types in case a developer has some basic options they just want to use everywhere.

[roji]

Sure. Though just having two global/singleton instances (for each type) instead of just one doesn't seem too bad. I personally don't think there's anything urgent to do here, unless we maybe want to have them in a hierarchy...

[westey-m]

Unless I missed something, even introducing a hierarchy shouldn't be a breaking change, so agreed, not urgent.
I'd also hold off on the hierarchy until we have finished all our search variations, to avoid creating a bad hierarchy that needs to be broken again.

[markwallace-microsoft]

HybridSearchOptions doesn't validate top and skip but VectorSearchOptions does. Keeping this issue to resolve that inconsistency.