Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net: OllamaPromptExecutionSettings doesn't have NumPredict property #10227

Conversation

Puchaczov
Copy link
Contributor

Motivation and Context

OllamaPromptExecutionSettings does not have property NumPredict that allows to limit maximum allowed tokens to generate

Description

Proposed change just add missing field to the OllamaPromptExecutionSettings and make sure it will be used also within CreateRequest of OllamaTextGenerationService

related issue: #10226

@Puchaczov Puchaczov requested a review from a team as a code owner January 18, 2025 17:10
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel labels Jan 18, 2025
@github-actions github-actions bot changed the title OllamaPromptExecutionSettings doesn't have NumPredict property .Net: OllamaPromptExecutionSettings doesn't have NumPredict property Jan 18, 2025
@Puchaczov
Copy link
Contributor Author

Puchaczov commented Jan 18, 2025

@microsoft-github-policy-service agree

@microsoft-github-policy-service agree

@RogerBarreto RogerBarreto self-assigned this Jan 20, 2025
@markwallace-microsoft markwallace-microsoft added this pull request to the merge queue Jan 21, 2025
Merged via the queue into microsoft:main with commit d6f6af6 Jan 21, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants