diff --git a/pkg/telemetry/telemetry.go b/pkg/telemetry/telemetry.go index b8437d93d6b..3e0ed17c391 100644 --- a/pkg/telemetry/telemetry.go +++ b/pkg/telemetry/telemetry.go @@ -21,14 +21,13 @@ import ( var ( client appinsights.TelemetryClient version string - btoMb uint64 = 1024 + mbShift uint64 = 10 // property keys - kernelversion = "kernelversion" - allocatedmem = "allocmem" - totalallocatedmem = "totalallocmem" - sysmem = "sysmem" - goroutines = "goroutines" + kernelversion = "kernelversion" + allocatedmem = "allocmem" + sysmem = "sysmem" + goroutines = "goroutines" ) type Telemetry interface { @@ -155,18 +154,17 @@ func (t *TelemetryClient) heartbeat(ctx context.Context) { var m runtime.MemStats runtime.ReadMemStats(&m) props := map[string]string{ - kernelversion: kernelVersion, - allocatedmem: strconv.FormatUint(bToMb(m.Alloc), 10), - totalallocatedmem: strconv.FormatUint(bToMb(m.TotalAlloc), 10), - sysmem: strconv.FormatUint(bToMb(m.Sys), 10), - goroutines: strconv.Itoa(runtime.NumGoroutine()), + kernelversion: kernelVersion, + allocatedmem: strconv.FormatUint(bToMb(m.Alloc), 10), + sysmem: strconv.FormatUint(bToMb(m.Sys), 10), + goroutines: strconv.Itoa(runtime.NumGoroutine()), } t.TrackEvent("heartbeat", props) } func bToMb(b uint64) uint64 { - return b / btoMb / btoMb + return b >> mbShift } func (t *TelemetryClient) TrackEvent(name string, properties map[string]string) { diff --git a/pkg/telemetry/telemetry_test.go b/pkg/telemetry/telemetry_test.go index f94779d05c3..f81cda6fea0 100644 --- a/pkg/telemetry/telemetry_test.go +++ b/pkg/telemetry/telemetry_test.go @@ -130,3 +130,7 @@ func TestTelemetryClient_StopPerf(t *testing.T) { }) } } + +func TestBtoMB(t *testing.T) { + require.Equal(t, uint64(1), bToMb(1048576)) +}