Skip to content

Commit c1c2ea2

Browse files
authored
fix(lint-ci): Removing golang-lint govet deprecated parameter (#1359)
# Description After [deps: bump github.com/golangci/golangci-lint from 1.64.2 to 1.64.5 in /hack/tools](f4d8f16), all PR started failing the golangci-lint workflow. This PR removes a parameter that has been deprecated by golanci-lint. ## Related Issue No issue created. ## Checklist - [X] I have read the [contributing documentation](https://retina.sh/docs/Contributing/overview). - [X] I signed and signed-off the commits (`git commit -S -s ...`). See [this documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification) on signing commits. - [X] I have correctly attributed the author(s) of the code. - [X] I have tested the changes locally. - [X] I have followed the project's style guidelines. - [ ] I have updated the documentation, if necessary. - [ ] I have added tests, if applicable. ## Screenshots (if applicable) or Testing Completed See workflow below. ![image](https://github.com/user-attachments/assets/c1b0021d-5c02-4b21-bddd-e09171c91736) ## Additional Notes Syntax updated as per golang-lint documentation https://golangci-lint.run/usage/linters/#govet ![image](https://github.com/user-attachments/assets/f4e96ce2-7694-4dd6-b7bf-59be1767e271) ![image](https://github.com/user-attachments/assets/a0da406b-36d9-48f1-9dbf-a8a0824b0efb) https://github.com/golangci/golangci-lint/blob/a8b68a590a88bbde93b27f8bf02031cb1db78b2b/pkg/config/loader.go#L402-L407 ![image](https://github.com/user-attachments/assets/75eea0c1-1b19-468d-a511-35db13c0bd9e) --- Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more information on how to contribute to this project.
1 parent c7f5907 commit c1c2ea2

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

.golangci.yaml

+2-1
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ linters-settings:
4545
disabled-checks:
4646
- "hugeParam"
4747
govet:
48-
check-shadowing: true
48+
enable:
49+
- shadow
4950
lll:
5051
line-length: 200

0 commit comments

Comments
 (0)