From 70ea129fc39178a9103468cffa8b9c74e5c47ca3 Mon Sep 17 00:00:00 2001
From: Zadkiel Aharonian <zadkiel_aharonian@carrefour.com>
Date: Thu, 28 Mar 2024 17:12:37 +0100
Subject: [PATCH] feat(helm): add podmonitor (#154)

Add support for podMonitor in helm chart.

Testing done:
- podmonitor generated

![image](https://github.com/microsoft/retina/assets/8191198/357892cb-79eb-4355-80a8-06fb57c20d8a)

- prometheus discovered it

![image](https://github.com/microsoft/retina/assets/8191198/94f99bab-fd1f-45f2-8c2c-13aa2ba25a57)

Signed-off-by: Zadkiel AHARONIAN <zadkiel_aharonian@carrefour.com>
---
 .../helm/retina/templates/daemonset.yaml      |  6 ++-
 .../helm/retina/templates/podmonitor.yaml     | 38 +++++++++++++++++++
 .../controller/helm/retina/values.yaml        | 37 ++++++++++++++++++
 3 files changed, 79 insertions(+), 2 deletions(-)
 create mode 100644 deploy/manifests/controller/helm/retina/templates/podmonitor.yaml

diff --git a/deploy/manifests/controller/helm/retina/templates/daemonset.yaml b/deploy/manifests/controller/helm/retina/templates/daemonset.yaml
index acf69794a22..c4fa6f3f34c 100644
--- a/deploy/manifests/controller/helm/retina/templates/daemonset.yaml
+++ b/deploy/manifests/controller/helm/retina/templates/daemonset.yaml
@@ -58,7 +58,8 @@ spec:
           {{- end}}
           {{- end}}
           ports:
-          - containerPort: {{ .Values.retinaPort }}
+          - name: retina
+            containerPort: {{ .Values.retinaPort }}
           resources:
             limits:
               memory: {{ .Values.resources.limits.memory | quote }}
@@ -152,7 +153,8 @@ spec:
         - name: retinawin
           image: {{ .Values.image.repository }}:{{ .Values.image.tag }}
           ports:
-            - containerPort: {{ .Values.retinaPort }}
+          - name: retina
+            containerPort: {{ .Values.retinaPort }}
           command:
             - powershell.exe
             - -command
diff --git a/deploy/manifests/controller/helm/retina/templates/podmonitor.yaml b/deploy/manifests/controller/helm/retina/templates/podmonitor.yaml
new file mode 100644
index 00000000000..415289d9a2d
--- /dev/null
+++ b/deploy/manifests/controller/helm/retina/templates/podmonitor.yaml
@@ -0,0 +1,38 @@
+{{- if .Values.metrics.podMonitor.enabled }}
+apiVersion: monitoring.coreos.com/v1
+kind: PodMonitor
+metadata:
+  name: {{ include "retina.fullname" . }}
+  namespace: {{ ternary .Values.metrics.podMonitor.namespace .Values.namespace (not (empty .Values.metrics.podMonitor.namespace)) }}
+  labels:
+    k8s-app: {{ include "retina.name" . }}
+    {{- if .Values.metrics.podMonitor.additionalLabels }}
+    {{- .Values.metrics.podMonitor.additionalLabels | nindent 4 }}
+    {{- end }}
+spec:
+  podMetricsEndpoints:
+    - port: retina
+      path: /metrics
+      {{- if .Values.metrics.podMonitor.interval }}
+      interval: {{ .Values.metrics.podMonitor.interval }}
+      {{- end }}
+      {{- if .Values.metrics.podMonitor.scrapeTimeout }}
+      scrapeTimeout: {{ .Values.metrics.podMonitor.scrapeTimeout }}
+      {{- end }}
+      {{- if .Values.metrics.podMonitor.scheme }}
+      scheme: {{ .Values.metrics.podMonitor.scheme }}
+      {{- end }}
+      {{- if .Values.metrics.podMonitor.tlsConfig }}
+      tlsConfig: {{- .Values.metrics.podMonitor.tlsConfig | nindent 8 }}
+      {{- end }}
+      {{- if .Values.metrics.podMonitor.relabelings }}
+      relabelings: 
+      {{- .Values.metrics.podMonitor.relabelings | nindent 8 }}
+      {{- end }}
+  namespaceSelector:
+    matchNames:
+      - {{ .Values.namespace }}
+  selector:
+    matchLabels:
+      app: {{ include "retina.name" . }}
+{{- end }}
diff --git a/deploy/manifests/controller/helm/retina/values.yaml b/deploy/manifests/controller/helm/retina/values.yaml
index dc5c717cf2d..25ed386eff5 100644
--- a/deploy/manifests/controller/helm/retina/values.yaml
+++ b/deploy/manifests/controller/helm/retina/values.yaml
@@ -122,3 +122,40 @@ nodeSelector: {}
 ## Ref: https://kubernetes.io/docs/concepts/configuration/taint-and-toleration/
 ##
 tolerations: []
+
+metrics:
+  ## Prometheus Service Monitor
+  ## ref: https://github.com/coreos/prometheus-operator/blob/master/Documentation/api.md#endpoint
+  ##
+  podMonitor:
+    ## @param metrics.podMonitor.enabled Create PodMonitor Resource for scraping metrics using PrometheusOperator
+    ##
+    enabled: false
+    ## @param metrics.podMonitor.namespace Namespace in which the PodMonitor should be created
+    ##
+    namespace: ~
+    ## @param metrics.podMonitor.interval Specify the interval at which metrics should be scraped
+    ##
+    interval: 30s
+    ## @param metrics.podMonitor.scrapeTimeout Specify the timeout after which the scrape is ended
+    ##
+    scrapeTimeout: 30s
+    ## @param metrics.podMonitor.additionalLabels [object] Additional labels that can be used so PodMonitors will be discovered by Prometheus
+    ## ref: https://github.com/coreos/prometheus-operator/blob/master/Documentation/api.md#prometheusspec
+    ##
+    additionalLabels: {}
+    ## @param metrics.podMonitor.scheme Scheme to use for scraping
+    ##
+    scheme: http
+    ## @param metrics.podMonitor.tlsConfig [object] TLS configuration used for scrape endpoints used by Prometheus
+    ## ref: https://github.com/prometheus-operator/prometheus-operator/blob/master/Documentation/api.md#tlsconfig
+    ## e.g:
+    ## tlsConfig:
+    ##   ca:
+    ##     secret:
+    ##       name: existingSecretName
+    ##
+    tlsConfig: {}
+    ## @param metrics.podMonitor.relabelings [array] Prometheus relabeling rules
+    ##
+    relabelings: []