Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert patch added to DrawerLayoutAndroid to resolve flow linting issue. #14290

Open
Yajur-Grover opened this issue Jan 17, 2025 · 1 comment

Comments

@Yajur-Grover
Copy link
Contributor

Problem Description

In the 1/13 integration, there were some changes made to DrawerLayoutAndroid.js which broke the flow checks. Adding the FlowFixMeannotation changed the type of override from copy to patch, which this issue is tracking.

Link to the integration where the error originated

#14278

Link to commit

facebook/react-native#48569

Forked files

packages/react-native/Libraries/Components/DrawerAndroid/DrawerLayoutAndroid.js

Upstream PR

No response

Build Configuration

None

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Jan 17, 2025
@chrisglein
Copy link
Member

Question here is if this is a permanent patch, as the flow issue won't make sense upstream.
Since this is an Android only component, is the right resolution to add a full on flow ignore for this whole file? (assuming we're not forking it for any other reason)

@chrisglein chrisglein added this to the Next milestone Jan 27, 2025
@chrisglein chrisglein added enhancement and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) labels Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants