Fabric Text components do not provide their text value (Name) to accessibility tree

[chrisglein]

Problem Description

See that the Name property is not set for a Text component:

Not sure if this is part of incomplete work already tracked here: #11898

Relevant code as far as I can tell is here:

react-native-windows/vnext/Microsoft.ReactNative/Fabric/Composition/CompositionDynamicAutomationProvider.cpp

Lines 248 to 252 in a8aa860

	case UIA_NamePropertyId: {
	pRetVal->vt = VT_BSTR;
	auto wideName = ::Microsoft::Common::Unicode::Utf8ToUtf16(props->accessibilityLabel);
	pRetVal->bstrVal = SysAllocString(wideName.c_str());
	hr = pRetVal->bstrVal != nullptr ? S_OK : E_OUTOFMEMORY;

Steps To Reproduce

See chrisglein/artificial-chat#119 (comment)

Expected Results

Accessibility Name should default to the text value

CLI version

12.0.0-alpha.6

Environment

info Fetching system and libraries information...
System:
  OS: Windows 10 10.0.23528
  CPU: "(24) x64 AMD Ryzen Threadripper PRO 3945WX 12-Cores     "
  Memory: 37.38 GB / 63.86 GB
Binaries:
  Node:
    version: 18.17.1
    path: C:\Program Files\nodejs\node.EXE
  Yarn:
    version: 1.22.19
    path: C:\Program Files (x86)\Yarn\bin\yarn.CMD
  npm:
    version: 9.4.1
    path: C:\Program Files\nodejs\npm.CMD
  Watchman: Not Found
SDKs:
  Android SDK: Not Found
  Windows SDK:
    AllowDevelopmentWithoutDevLicense: Enabled
    AllowAllTrustedApps: Enabled
    Versions:
      - 10.0.18362.0
      - 10.0.19041.0
      - 10.0.22000.0
      - 10.0.22621.0
IDEs:
  Android Studio: Not Found
  Visual Studio:
    - 17.6.33829.357 (Visual Studio Community 2022)
    - 16.11.33801.447 (Visual Studio Community 2019)
Languages:
  Java: Not Found
  Ruby: Not Found
npmPackages:
  "@react-native-community/cli": Not Found
  react:
    installed: 18.2.0
    wanted: 18.2.0
  react-native:
    installed: 0.73.0-nightly-20230721-ccc50ddd2
    wanted: 0.73.0-nightly-20230721-ccc50ddd2
  react-native-windows:
    installed: 0.0.0-canary.693
    wanted: 0.0.0-canary.693
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: true
  newArchEnabled: false
iOS:
  hermesEnabled: Not found
  newArchEnabled: Not found

Target Platform Version

None

Target Device(s)

No response

Visual Studio Version

None

Build Configuration

None

Snack, code example, screenshot, or link to a repository

No response

[chrisglein]

Confirmed that something like this would work, but not sure if it's the right design to add knowledge of text in the CompositionDynamicAutomationProvider rather than have it surfaced a different way:

    case UIA_NamePropertyId: {
      pRetVal->vt = VT_BSTR;

      bool useAccessibilityLabel = true;
      if (props->accessibilityLabel.empty()) {
        auto textView = std::static_pointer_cast<::Microsoft::ReactNative::ParagraphComponentView>(strongView);
        if (textView) {
          auto wideName = ::Microsoft::Common::Unicode::Utf8ToUtf16(textView->AccessibilityName());
          pRetVal->bstrVal = SysAllocString(wideName.c_str());
          useAccessibilityLabel = false;
        }
      }

      if (pRetVal->bstrVal == nullptr) {
        auto wideName = ::Microsoft::Common::Unicode::Utf8ToUtf16(props->accessibilityLabel);
        pRetVal->bstrVal = SysAllocString(wideName.c_str());
      }
      
      hr = pRetVal->bstrVal != nullptr ? S_OK : E_OUTOFMEMORY;
      break;
    }

Will follow up about the right way to do this.

Update: Built this instead: chrisglein@a58cc6d