chore: support typed arrays in indexeddb #34949
Open
+52
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Overview
This pull request adds support for typed arrays in IndexedDB storage by extending the serialization and deserialization logic, updating relevant tests, and removing outdated documentation.
- Introduces new types, functions, and handling for converting typed arrays to/from base64 strings.
- Updates tests to store and retrieve typed arrays instead of regular strings.
- Removes the documentation note that previously mentioned a lack of support for typed arrays.
Reviewed Changes
| File | Description |
|---|---|
| packages/playwright-core/src/server/isomorphic/utilityScriptSerializers.ts | Adds typed array type definitions, conversion utilities, and updates parser logic. |
| tests/library/browsercontext-storage-state.spec.ts | Modifies test cases to use typed arrays for IndexedDB operations. |
| docs/src/api/class-browsercontext.md | Removes outdated note about lack of typed array support. |
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Skn0tt
force-pushed
the
indexeddb-typed-arrays
branch
from
0133258 to
1837b1b
Compare
This comment has been minimized.
This comment has been minimized.
dgozman
reviewed
Feb 27, 2025
| }; | ||
|
|
||
| function typedArrayToBase64(array: any) { | ||
| if (globalThis.Buffer) |
There was a problem hiding this comment.
Why have Node-specific code? It seems like btoa/atob should work both in the browser and in the Node.
There was a problem hiding this comment.
good question! I mostly copied from @pavelfeldman's gist. Pavel, why?
packages/playwright-core/src/server/isomorphic/utilityScriptSerializers.ts
Outdated
Show resolved
Hide resolved
packages/playwright-core/src/server/isomorphic/utilityScriptSerializers.ts
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
Test results for "tests 1"1 failed 7 flaky38029 passed, 650 skipped Merge workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on https://gist.github.com/pavelfeldman/4c7826893182ac9f85cc60ddbd7b2d11