chore: ignore GitHub Codespaces BROWSER env var

mxschmitt · mxschmitt · commit 607f680a1ddf · 2024-11-25T21:07:20.000Z
diff --git a/src/Playwright.TestAdapter/PlaywrightSettingsProvider.cs b/src/Playwright.TestAdapter/PlaywrightSettingsProvider.cs
@@ -40,7 +40,8 @@ public static string BrowserName
         get
         {
             var browserFromEnv = Environment.GetEnvironmentVariable("BROWSER")?.ToLowerInvariant();
-            if (!string.IsNullOrEmpty(browserFromEnv))
+            // GitHub Codespaces sets the BROWSER environment variable, ignore it if its bogus.
+            if (!string.IsNullOrEmpty(browserFromEnv) && !browserFromEnv!.StartsWith("/vscode/"))
             {
                 ValidateBrowserName(browserFromEnv!, "'BROWSER' environment variable", "\nTry to remove 'BROWSER' environment variable for using default browser");
                 return browserFromEnv!;

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,8 @@ public static string BrowserName`
`40`	`40`	`get`
`41`	`41`	`{`
`42`	`42`	`var browserFromEnv = Environment.GetEnvironmentVariable("BROWSER")?.ToLowerInvariant();`
`43`		`- if (!string.IsNullOrEmpty(browserFromEnv))`
	`43`	`+ // GitHub Codespaces sets the BROWSER environment variable, ignore it if its bogus.`
	`44`	`+ if (!string.IsNullOrEmpty(browserFromEnv) && !browserFromEnv!.StartsWith("/vscode/"))`
`44`	`45`	`{`
`45`	`46`	`ValidateBrowserName(browserFromEnv!, "'BROWSER' environment variable", "\nTry to remove 'BROWSER' environment variable for using default browser");`
`46`	`47`	`return browserFromEnv!;`