Fix for name length (#3776)

Fixes #3772

Co-authored-by: freddydk <[email protected]>

Author: freddydk

NuGet/Get-BcNuGetPackageId.ps1

@@ -48,7 +48,7 @@ function Get-BcNuGetPackageId {
     $packageIdTemplate = $packageIdTemplate.replace('{id}',$id).replace('{publisher}',$npublisher).replace('{tag}',$tag).replace('{version}',$version.Replace('.', '-')).Replace('..', '.').TrimEnd('.')
     # Max. Length of NuGet Package Id is 100 - we shorten the name part of the id if it is too long
     $packageId = $packageIdTemplate.replace('{name}',$nname)
-    if ($packageId.Length -ge 100) {
+    if ($packageId.Length -gt 100) {
         if ($nname.Length -gt ($packageId.Length - 99)) {
             $nname = $nname.Substring(0, $nname.Length - ($packageId.Length - 99))
         }

ReleaseNotes.txt

@@ -4,6 +4,7 @@ There are instances where sqlps does not work as expected when it is installed.
 Issue 1303 from AL-Go repository - renew federated token when access token needs renewal (works only for GitHub at this time)
 Issue 3590 EarliestMatching select option added to Download-BcNuGetPackageToFolder
 Regression when from PR 3760 - Push-BcNuGetPackage doesn't work on PowerSHell 5
+Issue 3772 Get-BcNuGetPackageId name length limit
 
 6.0.29
 Issue 3591 When using Publish-NAVApp to publish an app, which fails compilation in the service, the command might hang forever - the fix for this is a temporary hack put in place for the versions which doesn't work.