Nuget bug fixes (#3280)

Fixes microsoft/AL-Go#858
Dumps all installed appnames along with appids
Fixes wrong type of TrustedNuGetFeeds

---------

Co-authored-by: freddydk <[email protected]>

Author: freddydk

AppHandling/Run-AlPipeline.ps1

@@ -450,21 +450,20 @@ function GetInstalledAppIds {
     if ($useCompilerFolder) {
         $existingAppFiles = @(Get-ChildItem -Path (Join-Path $packagesFolder '*.app') | Select-Object -ExpandProperty FullName)
         $installedApps = @(GetAppInfo -AppFiles $existingAppFiles -compilerFolder $compilerFolder -cacheAppinfoPath (Join-Path $packagesFolder 'cache_AppInfo.json'))
-        $installedAppIds = @($installedApps | ForEach-Object { $_.AppId } )
         $compilerFolderAppFiles = @(Get-ChildItem -Path (Join-Path $compilerFolder 'symbols/*.app') | Select-Object -ExpandProperty FullName)
-        $installedAppIds += @(GetAppInfo -AppFiles $compilerFolderAppFiles -compilerFolder $compilerFolder -cacheAppinfoPath (Join-Path $compilerFolder 'symbols/cache_AppInfo.json') | ForEach-Object { $_.AppId } )
+        $installedApps += @(GetAppInfo -AppFiles $compilerFolderAppFiles -compilerFolder $compilerFolder -cacheAppinfoPath (Join-Path $compilerFolder 'symbols/cache_AppInfo.json'))
 
     }
     elseif (!$filesOnly) {
-        $installedAppIds = @(Invoke-Command -ScriptBlock $GetBcContainerAppInfo -ArgumentList $Parameters | ForEach-Object { $_.AppId })
+        $installedApps = @(Invoke-Command -ScriptBlock $GetBcContainerAppInfo -ArgumentList $Parameters)
     }
     else {
-        $installedAppIds = @()
+        $installedApps = @()
     }
-    Write-Host "::group::Installed AppIds"
-    $installedAppIds | ForEach-Object { Write-Host "- $_" }
+    Write-Host "::group::Installed Apps"
+    $installedApps | ForEach-Object { Write-Host "- $($_.AppId):$($_.Name)" }
     Write-Host "::endgroup::"
-    return $installedAppIds
+    return $installedApps.AppId
 }
 
 $telemetryScope = InitTelemetryScope -name $MyInvocation.InvocationName -parameterValues $PSBoundParameters -includeParameters @()
@@ -1397,7 +1396,7 @@ if ($gitHubActions) { Write-Host "::endgroup::" }
 }
 
 
-if ($InstallMissingDependencies) {
+if ((($testCountry) -or !($appFolders -or $testFolders -or $bcptTestFolders)) -and ($InstallMissingDependencies)) {
 $Parameters = @{
     "containerName" = $containerName
     "tenant" = $tenant

NuGet/Find-BcNuGetPackage.ps1

@@ -53,12 +53,12 @@ Function Find-BcNuGetPackage {
 
     $bestmatch = $null
     # Search all trusted feeds for the package
-    foreach($feed in (@(@{ "Url" = $nuGetServerUrl; "Token" = $nuGetToken; "Patterns" = @('*'); "Fingerprints" = @() })+$bcContainerHelperConfig.TrustedNuGetFeeds)) {
+    foreach($feed in (@([PSCustomObject]@{ "Url" = $nuGetServerUrl; "Token" = $nuGetToken; "Patterns" = @('*'); "Fingerprints" = @() })+$bcContainerHelperConfig.TrustedNuGetFeeds)) {
         if ($feed -and $feed.Url) {
             Write-Host "Search NuGetFeed $($feed.Url)"
-            if (!$feed.ContainsKey('Token')) { $feed.Token = '' }
-            if (!$feed.ContainsKey('Patterns')) { $feed.Patterns = @('*') }
-            if (!$feed.ContainsKey('Fingerprints')) { $feed.Fingerprints = @() }
+            if (!($feed.PSObject.Properties.Name -eq 'Token')) { $feed | Add-Member -MemberType NoteProperty -Name 'Token' -Value '' }
+            if (!($feed.PSObject.Properties.Name -eq 'Patterns')) { $feed | Add-Member -MemberType NoteProperty -Name 'Patterns' -Value @('*') }
+            if (!($feed.PSObject.Properties.Name -eq 'Fingerprints')) { $feed | Add-Member -MemberType NoteProperty -Name 'Fingerprints' -Value @() }
             $nuGetFeed = [NuGetFeed]::Create($feed.Url, $feed.Token, $feed.Patterns, $feed.Fingerprints)
             $packageIds = $nuGetFeed.Search($packageName)
             if ($packageIds) {