Issue #3467 (#3468)

freddydk · web-flow · commit 65337fc69dc3 · 2024-04-05T13:43:47.000+02:00
Fixes #3467 Issue 3467 Can't create a backup of a container with the Backup-BCContainerDatabases commandlet Use PowerShell 5 in places where invoke-sqlcmd or other functions from the SqlServer PowerShell module are used Co-authored-by: freddydk <freddydk@users.noreply.github.com>
diff --git a/AppHandling/Clean-BcContainerDatabase.ps1 b/AppHandling/Clean-BcContainerDatabase.ps1
@@ -96,7 +96,7 @@ try {
             $copyTables += @("Entitlement", "Entitlement Set", "Membership Entitlement")
         }
 
-        Invoke-ScriptInBCContainer -containerName $containerName -scriptblock { Param($platformVersion, $databaseName, $databaseServer, $databaseInstance, $copyTables, $multitenant)
+        Invoke-ScriptInBCContainer -containerName $containerName -usePwsh:$false -scriptblock { Param($platformVersion, $databaseName, $databaseServer, $databaseInstance, $copyTables, $multitenant)
         
             Write-Host "Stopping ServiceTier in order to replace database"
             Set-NavServerInstance -ServerInstance $ServerInstance -stop
@@ -196,7 +196,7 @@ try {
         if ($customconfig.Multitenant -eq "True") {
             
             Write-Host "Switching to multitenancy"
-            Invoke-ScriptInBCContainer -containerName $containerName -scriptblock { Param($databaseName, $databaseServer, $databaseInstance)
+            Invoke-ScriptInBCContainer -containerName $containerName -usePwsh:$false -scriptblock { Param($databaseName, $databaseServer, $databaseInstance)
                 $databaseServerInstance = $databaseServer
                 if ($databaseInstance) {
                     $databaseServerInstance += "\$databaseInstance"
diff --git a/AppHandling/Compile-AppInNavContainer.ps1 b/AppHandling/Compile-AppInNavContainer.ps1
@@ -363,7 +363,7 @@ try {
         # locate application version number in database if using SQLEXPRESS
         try {
             if (($customConfig.DatabaseServer -eq "localhost") -and ($customConfig.DatabaseInstance -eq "SQLEXPRESS")) {
-                $appVersion = Invoke-ScriptInBcContainer -containerName $containerName -scriptblock { Param($databaseName)
+                $appVersion = Invoke-ScriptInBcContainer -containerName $containerName -usePwsh:$false -scriptblock { Param($databaseName)
                     (invoke-sqlcmd -ServerInstance 'localhost\SQLEXPRESS' -ErrorAction Stop -Query "SELECT [applicationversion] FROM [$databaseName].[dbo].[`$ndo`$dbproperty]").applicationVersion
                 } -argumentList $customConfig.DatabaseName
                 $publishedApps += @{ "Name" = "Application"; "Publisher" = "Microsoft"; "Version" = $appversion }
diff --git a/Bacpac/Backup-NavContainerDatabases.ps1 b/Bacpac/Backup-NavContainerDatabases.ps1
@@ -49,7 +49,7 @@ try {
     }
     $containerBakFolder = Get-BcContainerPath -containerName $containerName -path $bakFolder -throw
 
-    Invoke-ScriptInBcContainer -containerName $containerName -ScriptBlock { Param($containerBakfolder, $bakFolder, $tenant, $databasecredential, $compress)
+    Invoke-ScriptInBcContainer -containerName $containerName -usePwsh:$false -ScriptBlock { Param($containerBakfolder, $bakFolder, $tenant, $databasecredential, $compress)
        
         function Backup {
             Param (
diff --git a/Bacpac/Export-NavContainerDatabasesAsBacpac.ps1 b/Bacpac/Export-NavContainerDatabasesAsBacpac.ps1
@@ -64,7 +64,7 @@ try {
     }
     $containerBacpacFolder = Get-BcContainerPath -containerName $containerName -path $bacpacFolder -throw
 
-    Invoke-ScriptInBcContainer -containerName $containerName -ScriptBlock { Param([PSCredential]$sqlCredential, $bacpacFolder, $tenant, $commandTimeout, $includeDacPac, $diagnostics, $additionalArguments, $doNotCheckEntitlements)
+    Invoke-ScriptInBcContainer -containerName $containerName -usePwsh:$false -ScriptBlock { Param([PSCredential]$sqlCredential, $bacpacFolder, $tenant, $commandTimeout, $includeDacPac, $diagnostics, $additionalArguments, $doNotCheckEntitlements)
     
         function CmdDo {
             Param(
diff --git a/Bacpac/Restore-DatabasesInNavContainer.ps1 b/Bacpac/Restore-DatabasesInNavContainer.ps1
@@ -70,7 +70,7 @@ try {
         $containerBakFolder = Get-BcContainerPath -containerName $containerName -path $bakFolder -throw
     }
 
-    Invoke-ScriptInBCContainer -containerName $containerName -scriptblock { Param($bakFolder, $bakFile, $databaseName, $tenant, $databaseFolder, $sqlTimeout)
+    Invoke-ScriptInBCContainer -containerName $containerName -usePwsh:$false -scriptblock { Param($bakFolder, $bakFile, $databaseName, $tenant, $databaseFolder, $sqlTimeout)
 
         function Restore {
             Param (
diff --git a/ContainerHandling/New-NavContainer.ps1 b/ContainerHandling/New-NavContainer.ps1
@@ -1978,7 +1978,7 @@ if (-not `$restartingInstance) {
 
         if ($SqlServerMemoryLimit -and $customConfig.databaseServer -eq "localhost" -and $customConfig.databaseInstance -eq "SQLEXPRESS") {
             Write-Host "Set SQL Server memory limit to $SqlServerMemoryLimit MB"
-            Invoke-ScriptInBCContainer -containerName $containerName -scriptblock { Param($SqlServerMemoryLimit)
+            Invoke-ScriptInBCContainer -containerName $containerName -usePwsh:$false -scriptblock { Param($SqlServerMemoryLimit)
                 Invoke-Sqlcmd -ServerInstance 'localhost\SQLEXPRESS' -Query "USE master EXEC sp_configure 'show advanced options', 1 RECONFIGURE WITH OVERRIDE;"
                 Invoke-Sqlcmd -ServerInstance 'localhost\SQLEXPRESS' -Query "USE master EXEC sp_configure 'max server memory', $SqlServerMemoryLimit RECONFIGURE WITH OVERRIDE;"
                 Invoke-Sqlcmd -ServerInstance 'localhost\SQLEXPRESS' -Query "USE master EXEC sp_configure 'show advanced options', 0 RECONFIGURE WITH OVERRIDE;"
@@ -2376,7 +2376,7 @@ if (-not `$restartingInstance) {
             if ($multitenant) {
                 Write-Host "Switching to multitenant"
                 
-                Invoke-ScriptInBCContainer -containerName $containerName -scriptblock {
+                Invoke-ScriptInBCContainer -containerName $containerName -usePwsh:$false -scriptblock {
                 
                     $customConfigFile = Join-Path (Get-Item "C:\Program Files\Microsoft Dynamics NAV\*\Service").FullName "CustomSettings.config"
                     [xml]$customConfig = [System.IO.File]::ReadAllText($customConfigFile)
diff --git a/Misc/Set-BcContainerFeatureKeys.ps1 b/Misc/Set-BcContainerFeatureKeys.ps1
@@ -26,7 +26,7 @@ $telemetryScope = InitTelemetryScope -name $MyInvocation.InvocationName -paramet
 try {
 
     if ($featureKeys.Keys.Count -ne 0) {    
-        Invoke-ScriptInBCContainer -containerName $containerName -ScriptBlock { Param([string] $tenant, [hashtable] $featureKeys) 
+        Invoke-ScriptInBCContainer -containerName $containerName -usePwsh:$false -ScriptBlock { Param([string] $tenant, [hashtable] $featureKeys) 
             $customConfigFile = Join-Path (Get-Item "C:\Program Files\Microsoft Dynamics NAV\*\Service").FullName "CustomSettings.config"
             [xml]$customConfig = [System.IO.File]::ReadAllText($customConfigFile)
             $databaseServer = $customConfig.SelectSingleNode("//appSettings/add[@key='DatabaseServer']").Value
diff --git a/ReleaseNotes.txt b/ReleaseNotes.txt
@@ -1,3 +1,7 @@
+6.0.15
+Issue 3467 Can't create a backup of a container with the Backup-BCContainerDatabases commandlet
+Use PowerShell 5 in places where invoke-sqlcmd or other functions from the SqlServer PowerShell module are used
+
 6.0.14
 Issue 3465 Regression: Flush-ContainerHelperCache calculates wrong CacheFolder
 
diff --git a/Version.txt b/Version.txt
@@ -1 +1 @@
-﻿6.0.14-dev
+﻿6.0.15-dev

Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@ try {`
`49`	`49`	`}`
`50`	`50`	`$containerBakFolder = Get-BcContainerPath -containerName $containerName -path $bakFolder -throw`
`51`	`51`
`52`		`- Invoke-ScriptInBcContainer -containerName $containerName -ScriptBlock { Param($containerBakfolder, $bakFolder, $tenant, $databasecredential, $compress)`
	`52`	`+ Invoke-ScriptInBcContainer -containerName $containerName -usePwsh:$false -ScriptBlock { Param($containerBakfolder, $bakFolder, $tenant, $databasecredential, $compress)`
`53`	`53`
`54`	`54`	`function Backup {`
`55`	`55`	`Param (`
Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ try {`
`64`	`64`	`}`
`65`	`65`	`$containerBacpacFolder = Get-BcContainerPath -containerName $containerName -path $bacpacFolder -throw`
`66`	`66`
`67`		`- Invoke-ScriptInBcContainer -containerName $containerName -ScriptBlock { Param([PSCredential]$sqlCredential, $bacpacFolder, $tenant, $commandTimeout, $includeDacPac, $diagnostics, $additionalArguments, $doNotCheckEntitlements)`
	`67`	`+ Invoke-ScriptInBcContainer -containerName $containerName -usePwsh:$false -ScriptBlock { Param([PSCredential]$sqlCredential, $bacpacFolder, $tenant, $commandTimeout, $includeDacPac, $diagnostics, $additionalArguments, $doNotCheckEntitlements)`
`68`	`68`
`69`	`69`	`function CmdDo {`
`70`	`70`	`Param(`
Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,7 @@ try {`
`70`	`70`	`$containerBakFolder = Get-BcContainerPath -containerName $containerName -path $bakFolder -throw`
`71`	`71`	`}`
`72`	`72`
`73`		`- Invoke-ScriptInBCContainer -containerName $containerName -scriptblock { Param($bakFolder, $bakFile, $databaseName, $tenant, $databaseFolder, $sqlTimeout)`
	`73`	`+ Invoke-ScriptInBCContainer -containerName $containerName -usePwsh:$false -scriptblock { Param($bakFolder, $bakFile, $databaseName, $tenant, $databaseFolder, $sqlTimeout)`
`74`	`74`
`75`	`75`	`function Restore {`
`76`	`76`	`Param (`