Disallow invoking Run-ALPipeline with keepContainer without specifying credential (#3375)

If `keepContainer` is specified, `credential` must also be specified, as
otherwise the container will be created with a random password and there
will be no way to access it.

Author: mazhelez

AppHandling/Run-AlPipeline.ps1

@@ -411,7 +411,7 @@ function CheckRelativePath([string] $baseFolder, [string] $sharedFolder, $path,
     $path
 }
 
-Function UpdateLaunchJson {
+function UpdateLaunchJson {
     Param(
         [string] $launchJsonFile,
         [System.Collections.Specialized.OrderedDictionary] $launchSettings
@@ -485,6 +485,17 @@ if ($sharedFolder -and !(Test-Path $sharedFolder -PathType Container)) {
     throw "If sharedFolder is specified, it must be an existing folder"
 }
 
+if($keepContainer -and !$credential) {
+    # If keepContainer is specified, credentials must also be specified, as otherwise the container will be created with a random password and there will be no way to access it.
+    throw "If keepContainer is specified, you must also specify credentials"
+}
+
+if(!$credential) {
+    # Create a random password to use, as the container will not be kept after the pipeline finishes.
+    $password = GetRandomPassword
+    $credential= (New-Object pscredential 'admin', (ConvertTo-SecureString -String $password -AsPlainText -Force))
+}
+
 if ($memoryLimit -eq "") {
     $memoryLimit = "8G"
 }
@@ -662,15 +673,6 @@ Write-Host -NoNewLine -ForegroundColor Yellow "useCompilerFolder               "
 Write-Host -NoNewLine -ForegroundColor Yellow "artifactCachePath               "; Write-Host $artifactCachePath
 Write-Host -NoNewLine -ForegroundColor Yellow "useDevEndpoint                  "; Write-Host $useDevEndpoint
 Write-Host -NoNewLine -ForegroundColor Yellow "Auth                            "; Write-Host $auth
-Write-Host -NoNewLine -ForegroundColor Yellow "Credential                      ";
-if ($credential) {
-    Write-Host "Specified"
-}
-else {
-    $password = GetRandomPassword
-    Write-Host "Username: admin, Password: ***"
-    $credential= (New-Object pscredential 'admin', (ConvertTo-SecureString -String $password -AsPlainText -Force))
-}
 Write-Host -NoNewLine -ForegroundColor Yellow "CompanyName                     "; Write-Host $companyName
 Write-Host -NoNewLine -ForegroundColor Yellow "MemoryLimit                     "; Write-Host $memoryLimit
 Write-Host -NoNewLine -ForegroundColor Yellow "FailOn                          "; Write-Host $failOn

ReleaseNotes.txt

@@ -8,6 +8,7 @@ Check-BcContainerHelperPermissions didn't work on PS7
 Issue #3379 Adding -installCertificateOnHost to New-BcContainer didn't work when running PS7 (silently failed)
 Issue #3376 Regression - Download-Artifacts stopped downloading pre-requisites
 Issue 3371 Unable to get companyname from Windows Users when running tests
+Disallow invoking Run-ALPipeline with `keepContainer` without specifying credentials to use
 
 6.0.6
 Include Microsoft_Business Foundation Test Libraries.app when importing test libraries (and tests)
@@ -26,7 +27,7 @@ Proof of concept support for hosting artifacts as Universal Packages
 Add new function Get-BcNuGetPackageId to get a NuGet Package Id based on publisher, name, id and version
 Issue 3301 Run-AlValidation fails running AppsourceCop "Could not load type 'System.Object' from assembly 'System.Private.CoreLib'
 Give better error message if GitHub CLI, GIT or dotnet is not installed
-Issue 3301 Run-AlValidation fails running AppsourceCop "Could not load type 'System.Object' from assembly 'System.Private.CoreLib' (Regression in 6.0.4) 
+Issue 3301 Run-AlValidation fails running AppsourceCop "Could not load type 'System.Object' from assembly 'System.Private.CoreLib' (Regression in 6.0.4)
 Issue 3313 Strange error in Copy-BcEnvironment
 Issue 3318 Download-BcNuGetPackageToFolder fails when no dependencies defined
 Add Stacktrace output to high level functions Download-BcNuGetPackageToFolder and Get-BcNuGetPackage