Skip to content

Commit 0be5725

Browse files
ronaldnlfreddydk
andauthored
Changed local variable casing (#3342)
As described in issue [3339](#3339). The casing causes the command to fail. I changed both local vars to start on all places with a non capital to solve the issue which will make the command fail --------- Co-authored-by: Freddy Kristiansen <[email protected]>
1 parent a17e074 commit 0be5725

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

AzureAD/New-AadAppsForBc.ps1

+6-6
Original file line numberDiff line numberDiff line change
@@ -166,11 +166,11 @@ try {
166166
-Info @{ "LogoUrl" = $iconPath } `
167167
-RequiredResourceAccess $resourceAccessList
168168

169-
$admspwd = Add-MgApplicationPassword -ApplicationId $SsoAdApp.Id -PasswordCredential @{ "DisplayName" = "Password" }
169+
$admspwd = Add-MgApplicationPassword -ApplicationId $ssoAdApp.Id -PasswordCredential @{ "DisplayName" = "Password" }
170170
$AdProperties["SsoAdAppKeyValue"] = $admspwd.SecretText
171171

172-
$SsoAdAppId = $ssoAdApp.AppId.ToString()
173-
$AdProperties["SsoAdAppId"] = $SsoAdAppId
172+
$ssoAdAppId = $ssoAdApp.AppId.ToString()
173+
$AdProperties["SsoAdAppId"] = $ssoAdAppId
174174

175175
# Get oauth2 permission id for sso app
176176
$oauth2permissionid = [GUID]::NewGuid().ToString()
@@ -190,7 +190,7 @@ try {
190190
if ($IncludeApiAccess) {
191191
$appRoleId = [Guid]::NewGuid().ToString()
192192
Update-MgApplication `
193-
-ApplicationId $ssoAdApp.id `
193+
-ApplicationId $ssoAdApp.Id `
194194
-AppRoles @{
195195
"Id" = $appRoleId
196196
"DisplayName" = "API.ReadWrite.All"
@@ -216,7 +216,7 @@ try {
216216
# Create AD Application
217217
Write-Host "Creating AAD App for API Access"
218218
$bcSSOAppRRA = New-Object -TypeName Microsoft.Graph.PowerShell.Models.MicrosoftGraphRequiredResourceAccess
219-
$bcSSOAppRRA.ResourceAppId = "$SsoAdAppId" # BC SSO App
219+
$bcSSOAppRRA.ResourceAppId = "$ssoAdAppId" # BC SSO App
220220
$bcSSOAppRRA.ResourceAccess = @(
221221
@{ "Id" = "$oauth2permissionid"; "Type" = "Scope" } # OAuth2
222222
@{ "Id" = "$appRoleId"; "Type" = "Role" } # API.ReadWrite.All
@@ -270,7 +270,7 @@ try {
270270
# Create AD Application
271271
Write-Host "Creating AAD App for Excel Add-in"
272272
$bcSSOAppRRA = New-Object -TypeName Microsoft.Graph.PowerShell.Models.MicrosoftGraphRequiredResourceAccess
273-
$bcSSOAppRRA.ResourceAppId = "$SsoAdAppId" # BC SSO App
273+
$bcSSOAppRRA.ResourceAppId = "$ssoAdAppId" # BC SSO App
274274
$bcSSOAppRRA.ResourceAccess = @(
275275
@{ "Id" = "$oauth2permissionid"; "Type" = "Scope" } # OAuth2
276276
)

0 commit comments

Comments
 (0)