[FIX] PreparedStatement.executeBatch() When the Insert Sql Column Name Case Mismatch, Throws SQLServerException "Unable to retrieve column metadata." #2589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
Jeffery-Wasty
requested review from
divang,
Ananya2,
muskan124947 and
machavan
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
src/test/java/com/microsoft/sqlserver/jdbc/unit/statement/BatchExecutionTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/microsoft/sqlserver/jdbc/unit/statement/BatchExecutionTest.java
Show resolved
Hide resolved
src/test/java/com/microsoft/sqlserver/jdbc/unit/statement/BatchExecutionTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/microsoft/sqlserver/jdbc/unit/statement/BatchExecutionTest.java
Outdated
Show resolved
Hide resolved
lilgreenbird
requested changes
Jan 23, 2025
- Add test case for matching column case in batch execution - Add test case for mismatched column case in batch execution, expected SQLServerException
- Update column index search to be case-insensitive in SQLServerPreparedStatement - Remove failing test case in BatchExecutionTest that was checking for specific exception
wooln
force-pushed
the
bugfix-execute-batch-case-sensitive
branch
from
719687f to
902ac88
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
David-Engel
reviewed
Jan 23, 2025
There was a problem hiding this comment.
Something to consider:
Does your database use a case-sensitive (like SQL_Latin1_General_CP1_CS_AS) or case-insensitive collation (like SQL_Latin1_General_CP1_CI_AS)?
What happens if you are using a case-sensitive collation and a table like this?
create table [Test1] ([C1] int, [c1] varchar)
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
src/test/java/com/microsoft/sqlserver/jdbc/unit/statement/BatchExecutionTest.java
Outdated
Show resolved
Hide resolved
mmimica
reviewed
Jan 29, 2025
| int columnIndex = -1; | ||
| for (int opi = 0; opi < bcOperationColumnList.size(); opi++) { | ||
| if (bcOperationColumnList.get(opi).equalsIgnoreCase(c.getColumnName())) { | ||
| columnIndex = opi; |
There was a problem hiding this comment.
Suggested change
| columnIndex = opi; | |
| columnIndex = opi; | |
| break; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2588 [BUG] PreparedStatement.executeBatch() When the Insert Sql Column Name Case Mismatch, Throws SQLServerException "Unable to retrieve column metadata."