Changed the scope of BULK_COPY_OPERATION_CACHE to connection. #2594
+17
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machavan
requested review from
tkyc,
Jeffery-Wasty,
divang,
lilgreenbird and
David-Engel
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2594 +/- ##
============================================
- Coverage 51.22% 51.21% -0.01%
- Complexity 3953 3960 +7
============================================
Files 147 147
Lines 33657 33661 +4
Branches 5624 5625 +1
============================================
Hits 17241 17241
- Misses 13999 14004 +5
+ Partials 2417 2416 -1 ☔ View full report in Codecov by Sentry. |
|
More importantly, it solves a problem when a driver instance is used to connect to different SQLServers. Tables from different databases could end up in the same static cache. |
David-Engel
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The BULK_COPY_OPERATION_CACHE should be defined at connection scope and not global scope to avoid incorrect cache hits across connections and potential OOM issues.
Testing: